From owner-svn-ports-all@FreeBSD.ORG Sat Jul 13 05:54:33 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 57039475 for ; Sat, 13 Jul 2013 05:54:33 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-la0-f53.google.com (mail-la0-f53.google.com [209.85.215.53]) by mx1.freebsd.org (Postfix) with ESMTP id D1BA4122B for ; Sat, 13 Jul 2013 05:54:32 +0000 (UTC) Received: by mail-la0-f53.google.com with SMTP id fs12so8313570lab.12 for ; Fri, 12 Jul 2013 22:54:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=Ai6mDZKdXqvPeyI5XpMT7egrE8R5jD9ksmNTAtzJEbo=; b=FQuMhp2kG/pKDqnHE/MW/HRx/3eVToBCVXtae00uI55m3xGtb3Tkxrm1jzdqoZAi8W zUVv6VQR1oJlhOYCKF+P/Gw6PGzyPOxcIb8NitiIw83qpkHcMnbRfauplcL6WLHEcPMu ERW2RzNYlIKlbAK4z7QhLyItfgcdOZQhXvMcNXAXYgT7AnO9oten3Qg2pbOx0xcWG/QY b+VoahJTAklVcXXDPN3bUDcMnOPVeF2c9KvzGiXZ49vvcx0jGLOZs+9dwM0HYTNnH+qa WQGmep1Tct8v/Xf7f75YuGJTez3AUbUD7PO3lKUZtMFPluFHKT7inwaYIj70ZmdbJHx/ /Pww== X-Received: by 10.112.4.164 with SMTP id l4mr20481960lbl.94.1373694472176; Fri, 12 Jul 2013 22:47:52 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.112.27.161 with HTTP; Fri, 12 Jul 2013 22:47:32 -0700 (PDT) In-Reply-To: <51E036BF.6040807@FreeBSD.org> References: <201307111626.r6BGQRtt037769@svn.freebsd.org> <20130712161541.GN85556@ithaqua.etoilebsd.net> <51E036BF.6040807@FreeBSD.org> From: Sunpoet Po-Chuan Hsieh Date: Sat, 13 Jul 2013 13:47:32 +0800 X-Google-Sender-Auth: zfwxmZozIrgFvSDr_xoIbXfICXA Message-ID: Subject: Re: svn commit: r322783 - in head: archivers/epkg astro/foxtrotgps astro/viking audio/amarok-kde4 audio/ario audio/deadbeef audio/fplib audio/gbemol audio/gogglesmm audio/grip audio/gtkpod audio/herrie... To: Bryan Drewery X-Gm-Message-State: ALoCoQkbErkghYmQx0flop3bHkV1G7dTmA+4QhO5XJt33ZftZW4g0lEMu3DEYReIjppu+t1mp1cH Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-ports-head@freebsd.org, Baptiste Daroussin , svn-ports-all@freebsd.org, ports-committers X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jul 2013 05:54:33 -0000 Hi Bapt and Bryan, This commit was based on my old patch prior to bdrewery's fix. I didn't notice that change while updating the patch file. I've cleaned up :install targets. Thanks. Regards, On Sat, Jul 13, 2013 at 1:02 AM, Bryan Drewery wrote: > On 7/12/2013 11:15 AM, Baptiste Daroussin wrote: > > On Thu, Jul 11, 2013 at 04:26:27PM +0000, Sunpoet Po-Chuan Hsieh wrote: > >> Author: sunpoet > >> Date: Thu Jul 11 16:26:26 2013 > >> New Revision: 322783 > >> URL: http://svnweb.freebsd.org/changeset/ports/322783 > >> > > > > The diff has been truncated so I can't quote, but > > I see: > > LIB_DEPENDS+= curl.6:${PORTSDIR}/ftp/curl > > > > has become > > LIB_DEPENDS+= curl:${PORTSDIR}/ftp/curl:install > > > > Why ':install' ? > > > > The following are concerned: > > > > p5-WWW-Curl > > thundercache > > thundersnarf > > > > > > regards, > > Bapt > > > > Please do avoid that syntax. I previously cleaned it up in the tree: > > > r316958 | bdrewery | 2013-04-30 15:00:28 -0500 (Tue, 30 Apr 2013) | 6 > lines > > > > - Remove redundant :install target on LIB_DEPENDS and RUN_DEPENDS > > This fixes the following warning when running 'run-depends-list': > > "install" non-existent -- dependency list incomplete > > > > With hat: portmgr > > > -- > Regards, > Bryan Drewery > > -- Sunpoet Po-Chuan Hsieh 4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B http://people.FreeBSD.org/~sunpoet/pgpkeys.txt