From nobody Tue Feb 24 10:45:08 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fKvW85JVJz6ThXl for ; Tue, 24 Feb 2026 10:45:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fKvW82n6Kz42gl for ; Tue, 24 Feb 2026 10:45:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771929908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bNwOTQOtPw9SB6Z+WRxs8LcpNEW9qeMy/z3FaAzvFRw=; b=QWIg5Sz3oHO7H8GZgaSr4JuKsdItWIYE3dBzdB8jZQAigwZwu5vac0/kjVOdgvT4SsM4jZ u+Q/DJ/YZhq65iGUFWIWqKIvx57m/zRAQ/BFmYXxl4KhrO+7ABlgPM5dEP3pGS2+6xiL3N 9043t1iXRIw2PHAEC6Gc5SKQ4yLu96vj5UyXnYgRx/57TfWXT9u/mCKfbAT7EtWamGnUjo DN5Qd/d3QxhoXXIW92J64jknybyI5IDtwR/8f77RFwzjj6rDu3LOS5hZULB/GcwZBnFbZ4 aKtNKumwKCtvlaMz8AIdylmAuJZYyBRrOMUjZJsUShVVQKPZxnzKcQjWNYb+Yw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771929908; a=rsa-sha256; cv=none; b=llNvVtzPycNmcRICFjoTA6bk+21AslLMLgBLr1d02nfy4gv2C+mFip5fJ5uuxP+FmniYR2 il4qytVxeLsf7dJ6qEMCjgnBZTsVlQygDt80RjxPTDLZWVn4gJ0YDGyt2rqzFe414C/Zqk JLNO3cN1ZDLxW4ycQ6VBZiUafIl7n4IU8CSa38i/l+G75UvzJcndP1huSu3JyS4n3nMh/V Je3zeEtFzLc/vhID9zCpDUp/TrgzhIAfhVlttuZdb+uTmKZ/hkn6hfCwq3Ol+xhd9Z/DnC RSUjZ7GWe9X+80CrqCii8M+nyZp6ouCaBL9NpVab6zvoQm/YstWGhOgkLmfKbg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771929908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bNwOTQOtPw9SB6Z+WRxs8LcpNEW9qeMy/z3FaAzvFRw=; b=oaL/nYctJYrsm5g74P3Up0Z03ex/PZEfqJCu3vfhjdlQBoeq36D9kgS1jC/lWY684T+DAm fPGFEdZfboHW3+3e7KSYiEhZDoVOZjTZ8ej4zE2W8+nhEfSWCE3TYmyQl7enKttLQ7yAzn elHBpxENrBVoxNhQDri88AsJudN+ZtnOWQk6AoSVIjOiaEAKySEkB8pUltnpb98ZCgSL9W eMkZFZwKLT+h7ot/ibZrlhPG0CRlItjR7z12ZlpI3C6wD3TiKg0gQxySPGW/q1VwQmm+r+ m860UkUILAy1+/6VlwUMr8i+Y5Tx/Aut/wncSWdRo1ir1tsJz3YUsp3uVJUbxA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fKvW822Wrz1Bcr for ; Tue, 24 Feb 2026 10:45:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 36618 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 24 Feb 2026 10:45:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: fb463bcd621b - stable/13 - qlnxe: Fix setting the unicast MAC filter of RX path List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: fb463bcd621b78351d0ff91e60071ea9cbda05bc Auto-Submitted: auto-generated Date: Tue, 24 Feb 2026 10:45:08 +0000 Message-Id: <699d8134.36618.3aeec826@gitrepo.freebsd.org> The branch stable/13 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=fb463bcd621b78351d0ff91e60071ea9cbda05bc commit fb463bcd621b78351d0ff91e60071ea9cbda05bc Author: Zhenlei Huang AuthorDate: 2026-02-06 17:52:53 +0000 Commit: Zhenlei Huang CommitDate: 2026-02-24 10:15:36 +0000 qlnxe: Fix setting the unicast MAC filter of RX path When an Ethernet interface is added to lagg(4) as a child interface, its type, aka if_type, is changed from IFT_ETHER to IFT_IEEE8023ADLAG. Well changing the link-layer address of the lagg(4) interface will be propagated to all child interfaces, hence the drivers of child interfaces shall not presume the type of the interface will not be changed. Meanwhile, on initializing, an ifnet has been fully attached and it is guaranteed to have non-null link-layer address so stop NULL checking for it. Reviewed by: kbowling Fixes: 792226e53023 qlnxe: Allow MAC address override MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54885 (cherry picked from commit f250852c9a0c1021c3be4b498e27cfc7b42a81db) (cherry picked from commit 6d138e958ffb318595eec29b910cada414e2f86d) (cherry picked from commit 93719f8c8348a5d13c9037352072ce67f530288b) --- sys/dev/qlnx/qlnxe/qlnx_os.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index a9acfffee629..28aeaa784e14 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -7185,18 +7185,10 @@ qlnx_set_rx_mode(qlnx_host_t *ha) int rc = 0; uint8_t filter; const struct ifnet *ifp = ha->ifp; - struct sockaddr_dl *sdl; - if (ifp->if_type == IFT_ETHER && ifp->if_addr != NULL && - ifp->if_addr->ifa_addr != NULL) { - sdl = (struct sockaddr_dl *) ifp->if_addr->ifa_addr; - - rc = qlnx_set_ucast_rx_mac(ha, ECORE_FILTER_REPLACE, LLADDR(sdl)); - } else { - rc = qlnx_set_ucast_rx_mac(ha, ECORE_FILTER_REPLACE, ha->primary_mac); - } - if (rc) - return rc; + rc = qlnx_set_ucast_rx_mac(ha, ECORE_FILTER_REPLACE, IF_LLADDR(ifp)); + if (rc) + return rc; rc = qlnx_remove_all_mcast_mac(ha); if (rc)