Date: Thu, 14 Mar 2013 17:46:30 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Jason Helfman <jgh@FreeBSD.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Beech Rintoul <beech@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r314117 - head/games/kye Message-ID: <20130314174630.GA35403@FreeBSD.org> In-Reply-To: <CAMuy=%2Bg7Jj1N6Fo9YqoJsPngBEr_ajmThRo0uKWDq1U86UfpVg@mail.gmail.com> References: <201303132159.r2DLx1QL092713@svn.freebsd.org> <20130314070455.GA42406@hatter> <20130314075330.GA94901@FreeBSD.org> <201303132359.22984.beech@freebsd.org> <20130314081701.GA6014@FreeBSD.org> <CAMuy=%2BhkQ%2BqieiwX97%2BC9jfAkGVOzrAwvh0cTeQ1Z1dYU0Scag@mail.gmail.com> <20130314165712.GA8275@FreeBSD.org> <CAMuy=%2Bg7Jj1N6Fo9YqoJsPngBEr_ajmThRo0uKWDq1U86UfpVg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 14, 2013 at 10:37:51AM -0700, Jason Helfman wrote: > On Thu, Mar 14, 2013 at 9:57 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > > Do you still disagree that PORTDOCS lines should be removed from pkg-plist > > in favor of PORTDOCS set in the Makefile? > > I completely agree with you, however since PLIST_SUB isn't doing anything > in the Makefile, nor the pkg-plist, I really don't see the use for it. For > some reason, the maintainer is using it, and I trusted that it had built > fine per committer. It's not about PLIST_SUB being in the Makefile, or pkg-plist, or anywhere :) In fact, it's not about PLIST_SUB logic at all, it's perfectly fine. The problem is that having *both* PORTDOCS being set in Makefile and the very same docs listed in pkg-plist is wrong, and should be fixed, for the obvious reasons. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130314174630.GA35403>