From owner-dev-commits-src-main@freebsd.org Fri Jan 8 22:21:24 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 464094D8672; Fri, 8 Jan 2021 22:21:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DCHd01FqSz3MFH; Fri, 8 Jan 2021 22:21:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (unknown [IPv6:2601:648:8681:1cb0:8974:ab93:8119:cfc9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id E4F044A65; Fri, 8 Jan 2021 22:21:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: 92cf602e3809 - main - Copy strcasestr.c from libc to libkern. To: Kyle Evans , Baptiste Daroussin Cc: Vladimir Kondratyev , Ravi Pokala , Jessica Clarke , Vladimir Kondratyev , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202101072320.107NKpMS063374@gitrepo.freebsd.org> <7a7fa0fb-51c2-1b14-6d37-2c400f69d7dd@kondratyev.su> <3EA011C9-2EEC-4693-B36D-69E74DF8473C@panasas.com> <20210108092638.x2kkvpeftey2wk62@ivaldir.net> From: John Baldwin Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: <4628ea93-876c-be1c-1012-bc4353e0b31d@FreeBSD.org> Date: Fri, 8 Jan 2021 14:21:21 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2021 22:21:24 -0000 On 1/8/21 5:46 AM, Kyle Evans wrote: > On Fri, Jan 8, 2021 at 3:27 AM Baptiste Daroussin wrote: >> >> On Fri, Jan 08, 2021 at 02:49:31AM +0300, Vladimir Kondratyev wrote: >>> On 08.01.2021 02:41, Ravi Pokala wrote: >>>> -----Original Message----- >>>> From: on behalf of Vladimir Kondratyev >>>> Date: 2021-01-07, Thursday at 15:33 >>>> To: Jessica Clarke , Vladimir Kondratyev >>>> Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" >>>> Subject: Re: git: 92cf602e3809 - main - Copy strcasestr.c from libc to libkern. >>>> >>>> On 08.01.2021 02:27, Jessica Clarke wrote: >>>> > On 7 Jan 2021, at 23:20, Vladimir Kondratyev wrote: >>>> >> +#include >>>> >> +#include >>>> >> +#include "xlocale_private.h" >>>> >> + >>>> >> +/* >>>> >> + * Find the first occurrence of find in s, ignore case. >>>> >> + */ >>>> >> +char * >>>> >> +strcasestr_l(const char *s, const char *find, locale_t locale) >>>> > >>>> > Locales in the kernel? This feels wrong. >>>> > >>>> > Jess >>>> > >>>> >>>> strcasestr.c was copied from userland unmodified just to allow >>>> "git log --follow" to work. Next commit removed locale support from this >>>> file and connected it to build. >>>> >>>> Unfortunately, about two-dozen commit messages from you arrived at the same time, and some were out of order; without incrementing change numbers in the subject line, figuring out the actual ordering is non-trivial. :-p >>>> >>>> -Ravi (rpokala@) >>>> >>> >>> I hope, commit hook will be improved some day. Pushing of two-dozen >>> commits one by one is too boring. >> >> The history is in the right order and gitlog/cgit/anything that reads the log >> show everything in the right order. >> >> mails are asynchronuous, expecting the mail to always arrive in a given order is >> wrong ;) >> >> pushing all those commits at once was imho the right thing to do. >> > > I've pointed this out a couple of times (with seemingly nothing coming > from it), but the mails are being sent in reverse order. Fixing that > would at least increase chances for some to receive them in order (and > the archives show them perfectly in reverse order most of the time). > > Picking out the message-ids from the last series I sent, this is the > correct order: > > 202101072237.107MbYaX002789@gitrepo.freebsd.org ("4832d2e8ae1d - main > - du: tests: fix the H_flag test (primarily grep usage)") > 202101072237.107MbYsM002771@gitrepo.freebsd.org ("3c5c39c7ad8f - main > - du: tests: make H_flag tests more strict about output requirements") > > 202101072237.107MbYaX002789 -> 2789 was the last pid that assigned a message-id > 202101072237.107MbYsM002771 -> 2771 was the last pid that assigned a message-id > > Given that this is clearly with kern.randompid=0 on the server, one > can conclude that these were sent in the reverse order based on the > pid sequence. If you pick a couple other series out, this holds true > (at least for all the series I've looked at) I believe Li-wen and Uli tracked this down today and that this might be fixed going forward (needed to add --reverse to git rev-list to build the list of commits to generate e-mails for) -- John Baldwin