From owner-freebsd-testing@freebsd.org Wed Nov 20 16:18:42 2019 Return-Path: Delivered-To: freebsd-testing@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CDC881BACCE; Wed, 20 Nov 2019 16:18:42 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47J7D254Vhz40v6; Wed, 20 Nov 2019 16:18:42 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-ot1-f54.google.com with SMTP id b16so44651otk.9; Wed, 20 Nov 2019 08:18:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7cVwY+LN01eZxRUKFa7GjLY9S2a52DbUmZAIFfhVhHc=; b=OQrXnf2lWNY/rSD6NHm2q6bslsSNwIcFB71j/LNldzBXuw5ioDNYZRzOgOqrvCG2Si WCpbajfoew7l9nK1sg4P/Lc3tyDBd2BmncfCkEIiCXsqGTUCKi7Vvk/AOD9ZPICGshZl X+dbl1iOiLyQhcCr+B9wH74qyibZItt1hsbjf4p6LB9UuvfGYE4C59oNleRBGwDP3ox4 mq6JNdB9rrA8xvRfHVlzwLqelcR5v8AjWr7K7bYtBYToKKYgxAxSvwYZOYnUNBO//ZtO Hr/YUYsgOz9dk11yOFcuP27iMTXQQBOGdhCsxSgFIF5P/XXkFi+YI7GOGXDPua7hp+Zx WEYQ== X-Gm-Message-State: APjAAAVKQrwiVx5EV4F+iQfVkirEPbq+ZK2a05jQCSVq2AoK0VAj6rTf GlHUJPFLCc8my05O9q4bUxoAp8oRprjlJqkuOkX2i/1L X-Google-Smtp-Source: APXvYqxZ/oDUVvK9rtDqMxKn6xKtLtbldn48h6MFNKvccD+mmdYi9630TewjgU3Z+wxb/nP5c1PH9GwWdbtBB6OCGk8= X-Received: by 2002:a05:6830:1e0a:: with SMTP id s10mr2695985otr.18.1574266720879; Wed, 20 Nov 2019 08:18:40 -0800 (PST) MIME-Version: 1.0 References: <1ef80fd8-d695-010f-9dc8-a6b9a2a80f8e@FreeBSD.org> In-Reply-To: <1ef80fd8-d695-010f-9dc8-a6b9a2a80f8e@FreeBSD.org> From: Alan Somers Date: Wed, 20 Nov 2019 09:18:27 -0700 Message-ID: Subject: Re: Revisiting the ZFS test suite To: Andriy Gapon Cc: freebsd-testing , freebsd-fs X-Rspamd-Queue-Id: 47J7D254Vhz40v6 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Nov 2019 16:18:42 -0000 On Wed, Nov 20, 2019 at 1:17 AM Andriy Gapon wrote: > On 04/10/2019 19:23, Alan Somers wrote: > > My employment status changed last week, and I find myself once again > > working on ZFS. It's hard to have confidence in any changes without a > > solid test suite, so my main task right now is to fix the problems in > > FreeBSD's ZFS test suite. Our most recent run had 64 failed tests and 99 > > skipped ones; let's get those down to 0 and something small, > respectively. > > > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test_zfs/3880/testReport/ > > > > Would anybody be interested to review my changes to the test suite? It's > > not terrible if I have to commit without review; I can't possibly break > > anything but the test suite itself. > > Alan, > > just curious, did you have any plans to merge new tests and changes to > existing > tests from illumos or ZoL? > I've imported quite a few code changes, many times there were test changes > or > new test, but I never took time to merge them. > > > -- > Andriy Gapon > We'll need to do it sooner or later, but it's going to take a large effort. I can't justify that much effort right now. And it will require changing ZoL's test suite, too, not just ours. We'll need to convince them to use ATF, for example. -Alan