From owner-freebsd-current@FreeBSD.ORG  Wed Jan 23 18:20:39 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 89FA328D
 for <freebsd-current@freebsd.org>; Wed, 23 Jan 2013 18:20:39 +0000 (UTC)
 (envelope-from jasone@freebsd.org)
Received: from canonware.com (canonware.com [204.109.63.53])
 by mx1.freebsd.org (Postfix) with ESMTP id 70A176A5
 for <freebsd-current@freebsd.org>; Wed, 23 Jan 2013 18:20:39 +0000 (UTC)
Received: from jemac.thefacebook.com (unknown [173.252.71.7])
 (using TLSv1 with cipher AES128-SHA (128/128 bits))
 (No client certificate requested)
 by canonware.com (Postfix) with ESMTPSA id 865EF286E2;
 Wed, 23 Jan 2013 10:20:33 -0800 (PST)
Subject: Re: Compilation error (pkgng)
Mime-Version: 1.0 (Apple Message framework v1283)
Content-Type: text/plain; charset=us-ascii
From: Jason Evans <jasone@freebsd.org>
In-Reply-To: <CANuCnH8A27v_n=JndXdQUWeV2Rn3zPhrD5Vj72fi+0_AfpEPQw@mail.gmail.com>
Date: Wed, 23 Jan 2013 10:20:32 -0800
Content-Transfer-Encoding: 7bit
Message-Id: <CDE2773E-A9EB-40EC-9714-FA96A2EE3C02@freebsd.org>
References: <CANuCnH8A27v_n=JndXdQUWeV2Rn3zPhrD5Vj72fi+0_AfpEPQw@mail.gmail.com>
To: Alie Tan <alie@affle.com>
X-Mailer: Apple Mail (2.1283)
Cc: freebsd-current@freebsd.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jan 2013 18:20:39 -0000

On Jan 23, 2013, at 12:14 AM, Alie Tan wrote:
> Seems this check-in causing compilation error:
> 
> http://freshbsd.org/commit/freebsd/r245828
> 
> -nonliteral -c /usr/src/usr.sbin/pkg_install/lib/pkgng.c -o pkgng.o
> /usr/src/usr.sbin/pkg_install/lib/pkgng.c:53:45: error: expected ')'
>        rc = snprintf(pkgngpath, sizeof(pkgngpath) "%s/local.sqlite",
> pkgngdir);
>                                                   ^
> /usr/src/usr.sbin/pkg_install/lib/pkgng.c:53:15: note: to match this '('
>        rc = snprintf(pkgngpath, sizeof(pkgngpath) "%s/local.sqlite",
> pkgngdir);
>                     ^
> /usr/src/usr.sbin/pkg_install/lib/pkgng.c:54:9: warning: comparison of
> integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
>        if (rc >= sizeof(pkgngpath)) {
>            ~~ ^  ~~~~~~~~~~~~~~~~~
> 1 warning and 1 error generated.

Fixed by r245837.

Thanks,
Jason