From owner-svn-src-all@freebsd.org Fri May 11 01:26:50 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1553BFAED72; Fri, 11 May 2018 01:26:50 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9738D7CB02; Fri, 11 May 2018 01:26:49 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io0-x22f.google.com with SMTP id g1-v6so5257126iob.2; Thu, 10 May 2018 18:26:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=P0xUteSJdznPNDdg3R5IXjh9nvE3jZBxmnUPjhxbik4=; b=YAbfADwTIcRN2kElgeEMd3h/2EYVtOOE57JiuMWC1d4pWS7zaQVHwGkd2xF87iL9X1 j1Rfw10K42DB80aWLsvBHsGZwg+dK/pvArdebj15r1ATLoAj1TjIbiLSRdaFnY2naTXr J0731XXMa9+lnUAv2bQjKPOFVrWgF+uAOjgOtbHG4dqFGQVG9p+Oix9VbDu76CeEMIX3 w0gKw1SD0gAUZbawgwW/LMVqeDfrLlc6mvWl9yEOFuvgajUVcbJbTsmsBDMWI7yWVXUo swoOJ8E0WlohmfWkXKx34XI5M3D04ykQrJHY30J+4twdDZjt79fOuJX+EWukhrSU5Ez8 fR1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=P0xUteSJdznPNDdg3R5IXjh9nvE3jZBxmnUPjhxbik4=; b=GreCHKn6h1A7aQ7StasAs5dLN3CRM1LXYszv/2zz6UIczx3izJx/gu8WQs5yYcyjaF sgBV+yB/o1agJBj8INq8qzL/p+8gDglIpTmjZJZrUfTGEIsc7cu9ZRmd1tLIa/hhmqHh rrh0wF63hgO7zT80midxuz2Uw8tOt0RWjvgY9cb9tNq/elw0nFt7DbkfAhhU7eDK1/kO hNAwvW0MNaDTaULw2f+5t2bYptHEug+0tyEbkivbMyAIVon57Gt9wmwY9B/qYY5gqNwO vaOrT+VIr+XmhkuPxWrm1j3SoFT/XFenbFjxTSLnQ9bVV9Jo03VvBA83+d2bfcgJ+6QB 0cnA== X-Gm-Message-State: ALKqPwe/RBBreyaREMdDtpMKbfLMqC5SeYo0RhntOHoyMg/FH9H3oPVh D5aknMfzttjm5dx6o+9J8LmpXd0Jogauf9KGuFA= X-Google-Smtp-Source: AB8JxZqaDJXQwUX55K2awp/ya2Kqw+3o6KG2xBmFuaAgdAS0k3JA0PQDHjV5cGfYFoczkr1jMOvnNzpWfT3ZeKxYkEg= X-Received: by 2002:a6b:298f:: with SMTP id p137-v6mr4006557iop.288.1526002009043; Thu, 10 May 2018 18:26:49 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.130.167 with HTTP; Thu, 10 May 2018 18:26:28 -0700 (PDT) In-Reply-To: References: <201805102010.w4AKA3Ww094768@repo.freebsd.org> <788634f4-7a63-36c9-2ebd-5842d464f324@cs.duke.edu> <31075786-70ed-10b9-fbc5-127996f87b1b@cs.duke.edu> <58b76dcb-b081-869b-8e05-dc0c4e7aa3be@cs.duke.edu> From: Ed Maste Date: Thu, 10 May 2018 21:26:28 -0400 X-Google-Sender-Auth: p1BTdjaejilxHOFGMzIfEWdOwAA Message-ID: Subject: Re: svn commit: r333470 - in head: share/mk sys/conf To: Warner Losh Cc: Andrew Gallatin , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Konstantin Belousov Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 01:26:50 -0000 On 10 May 2018 at 20:38, Warner Losh wrote: > > It's a shame we can't get a link-time error if a too-old ld is used rather > than silent failure. That's what this commit does: +.if defined(LINKER_FEATURES) && ${LINKER_FEATURES:Mifunc} == "" +.error amd64 kernel requires linker ifunc support +.endif Making ld.bfd itself error out (e.g., if it encounters STT_GNU_IFUNC as an unknown symbol type) could be done but would require that the patched ld.bfd be installed, defeating the purpose. The test has a possible false negative (producing a broken kernel instead of an error), if LINKER_FEATURES is not defined due to some unusual configuration. We could just drop the defined(LINKER_FEATURES) to avoid that, and introduce a possible false positive error.