From owner-svn-src-all@freebsd.org Sat Dec 10 10:35:21 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3D24C70BBD; Sat, 10 Dec 2016 10:35:21 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1B41412E2; Sat, 10 Dec 2016 10:35:20 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id uBAAZBPo084230 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 10 Dec 2016 12:35:11 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua uBAAZBPo084230 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id uBAAZBwG084228; Sat, 10 Dec 2016 12:35:11 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 10 Dec 2016 12:35:11 +0200 From: Konstantin Belousov To: Ngie Cooper Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r309774 - head/contrib/netbsd-tests/fs/tmpfs Message-ID: <20161210103511.GO54029@kib.kiev.ua> References: <201612092250.uB9MohnP008576@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201612092250.uB9MohnP008576@repo.freebsd.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Dec 2016 10:35:21 -0000 On Fri, Dec 09, 2016 at 10:50:43PM +0000, Ngie Cooper wrote: > Author: ngie > Date: Fri Dec 9 22:50:43 2016 > New Revision: 309774 > URL: https://svnweb.freebsd.org/changeset/base/309774 > > Log: > Only run mdconfig -d -u 3 if /dev/md3 exists on the system > > This will prevent "cleanup failures" (exit code != 0 returned) when > tmpfs is not loaded > > MFC after: 1 week > > Modified: > head/contrib/netbsd-tests/fs/tmpfs/t_vnd.sh > > Modified: head/contrib/netbsd-tests/fs/tmpfs/t_vnd.sh > ============================================================================== > --- head/contrib/netbsd-tests/fs/tmpfs/t_vnd.sh Fri Dec 9 22:13:00 2016 (r309773) > +++ head/contrib/netbsd-tests/fs/tmpfs/t_vnd.sh Fri Dec 9 22:50:43 2016 (r309774) > @@ -85,7 +85,7 @@ basic_cleanup() { > umount mnt 2>/dev/null 1>&2 > # Begin FreeBSD > if true; then > - atf_check -s eq:0 -o empty -e empty mdconfig -d -u 3 > + [ ! -c /dev/md3 ] || mdconfig -d -u 3 > else > # End FreeBSD > vndconfig -u /dev/vnd3 2>/dev/null 1>&2 Why this test is under fs/tmpfs ? I was not able to see how tmpfs is used for this test.