Date: Mon, 20 Jun 2011 08:12:51 +0200 From: Martin Matuska <mm@FreeBSD.org> To: "Justin T. Gibbs" <gibbs@scsiguy.com> Cc: fs@FreeBSD.org Subject: Re: [CFR][ZFS] Show removed devices by GUID in zpool output. Message-ID: <4DFEE4E3.2010509@FreeBSD.org> In-Reply-To: <4DF7C406.1080903@scsiguy.com> References: <4DF7C406.1080903@scsiguy.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I agree to this change, too. Dňa 14.06.2011 22:26, Justin T. Gibbs wrote / napísal(a): > The current behavior of zpool_vdev_name() is to report the vdev path > (e.g. /dev/da0) unless > a vdev has the ZPOOL_CONFIG_NOT_PRESENT attribute set. This attribute > is only set when > a vdev is not found during import/mount of a pool. The attached patch > also displays a vdev > by GUID if it cannot be opened post import or is marked removed (e.g. > via a GEOM orphan > event). > > The main motivation for this change is that vdev paths are not unique to > a physical leaf vdev. > It is easy to get into a situation where you need to "detach /dev/da0" > event though da0 is > an active member of the same pool in which a "previous da0" was once > removed. With > zpool_vdev_name() reporting the GUID, the user is equipped to provide an > unambiguous > command that represents their desired action. -- Martin Matuska FreeBSD committer http://blog.vx.sk
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DFEE4E3.2010509>