From owner-freebsd-current@FreeBSD.ORG Wed Aug 11 14:22:52 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2B1841065677 for ; Wed, 11 Aug 2010 14:22:52 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id D19938FC13 for ; Wed, 11 Aug 2010 14:22:51 +0000 (UTC) Received: by ywk9 with SMTP id 9so49527ywk.13 for ; Wed, 11 Aug 2010 07:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:openpgp:content-type:content-transfer-encoding; bh=Spc3S2+cg9/q5eHjol1ajof+0CadCKCCAEaSdX7bHis=; b=v5BB7b+rPVZaPjTo6Bo39OwDGNQMQoErRf785kDJldN8INmM8+NiPzWotiCNi2YmXP eh0uLPT9rhJbFujd9x6G0OxIBLew9KqeSR8u18EnN3TWL9f3uXEC1TdQcI362VTMJqkM IM5FAa5NkvY80OZH5ronkhPkrNFzrncaOsoQs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:openpgp:content-type :content-transfer-encoding; b=J+O4ExbuyFHdCnnJnLhypndC112WSv3tbJl/bNLbWqAbTbFnyCqt54UCSju3D2++I1 OLJIwySbd3aRjIevAM0Vcylls2c7o51I6hrnx2ClYxsekU1dtvQy4roUdcvbIv9gYzMR jdDyr+tUvPiZLJdr8NRR8w+scgVzYdCarNTRM= Received: by 10.150.58.20 with SMTP id g20mr20631431yba.24.1281536571035; Wed, 11 Aug 2010 07:22:51 -0700 (PDT) Received: from centel.dataix.local (adsl-99-19-46-227.dsl.klmzmi.sbcglobal.net [99.19.46.227]) by mx.google.com with ESMTPS id q12sm74894vcf.35.2010.08.11.07.22.48 (version=SSLv3 cipher=RC4-MD5); Wed, 11 Aug 2010 07:22:49 -0700 (PDT) Sender: "J. Hellenthal" Message-ID: <4C62B237.7070501@dataix.net> Date: Wed, 11 Aug 2010 10:22:47 -0400 From: jhell User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.8) Gecko/20100806 Lightning/1.0b1 Thunderbird MIME-Version: 1.0 To: Anonymous References: <4C61C50E.8040900__28807.0786548362$1281476071$gmane$org@dataix.net> <86sk2lxrvr.fsf@gmail.com> In-Reply-To: <86sk2lxrvr.fsf@gmail.com> X-Enigmail-Version: 1.1.2 OpenPGP: id=89D8547E Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-current@FreeBSD.org Subject: Re: [CFT] [sys/conf/newvers.sh] Cleanup and additions. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Aug 2010 14:22:52 -0000 On 08/11/2010 08:20, Anonymous wrote: > jhell writes: > >> Based on the parts of the script with the additions for tracking source >> using git(1) I set out to add support for mercurial hg(1) and ended up >> cleaning some of the script while making some of those additions. > > FYI, some ports don't like unusual characters in uname(1), e.g. ports/148255. Thank you for the heads-up. I can adjust for that. This was original git code from newvers.sh that I had let be what it is now and really holds no extra meaning to me unless it does to someone else?. Easy enough to change 137,13 to a space instead of equal sign. Questionable whether the '+' sign at 143,14 would cause any problems so I am testing that out now and will submit another followup patch. Does not make any sense to me why a port would configure using (uname -v) for identifying its environment. More specifically there should not be anything more needed than the output of ( uname -rms ) and maybe on occasion '-n' and __FreeBSD_version. I have had thoughts before about a patch for uname that also outputs the ABI or __FreeBSD_version but really don't see a need for that since it can already be identified by kernel headers or through the use of sysctl(8) or some system call. Regards, -- jhell,v