From owner-freebsd-net@freebsd.org Wed Sep 18 06:19:48 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 11199F28BE for ; Wed, 18 Sep 2019 06:19:48 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Y8w31ZCTz3Nd7 for ; Wed, 18 Sep 2019 06:19:46 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd2f.google.com with SMTP id v2so13409143iob.10 for ; Tue, 17 Sep 2019 23:19:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g1FU0Rc7ViQwbNgD2Ub3EyR8i3O1CDZgb5gqxjhm3Ow=; b=MIBeCGBQx4ZxuRgvAvPOKfn1uw0bUrEzAJL6BdOv9wz6RkBOEhSEOGW4NGeux0vMUh SFGag8B88kqjLTr8sE8QwaEbX7Wpghqp9ynlSvi5OrKto/ZtZbD92tyPhr6W+cFor2RN zQcmO6267F/sLvqb5ROi3Zuuh8S5cETV0zDyM2KijesVz3D/Bs3nP1BMVS3JF0QFvAqd l3m+oNbRWOA4Qf5KPh2pb8LMOiP9gvD6dkoBl4f1AkyPv3wsmzjKds2OylfsNQlMTNaH UEFXP/3VUiPSg1+32q+6fsOzZ7VX8bMEwLkX0WuHjMcszjfE+MgndI7eN1p2jE986AyB 8riA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g1FU0Rc7ViQwbNgD2Ub3EyR8i3O1CDZgb5gqxjhm3Ow=; b=h5QVgcQGA/UbjEvAoY0u+dTWcd1vaZRYjPOfKT9uH7xGtLPS/OHA/sQPj+iot3tnkf NmRDYXitt4JmaKX0DFyXrGNkKfPTM0XFBkXUkOwmTpyy1Jf4YT6Be+W1379iMgyxdzZC tGVImxT4+3YFKHoms1MxaQXh+qc+9iPe652Vw4lMd1PreD9nPQ+mK3WfgcvK8mSdGowY 0cU9Zxwc4ig6dne/ZwHCKpUrc7lBR3PjLMOPX/tOv/uvczy5nodF/wHHgI9UGWPcxI+r xc4W8UaKpuZX5nx2lH3IBWpHesJv+zmPVafXNyWTolBnY8U5xV8h9Gy1t80BxYSP2QAR SYOQ== X-Gm-Message-State: APjAAAXBhtDvF/2Ks+ctRtNbJQGWY72vWh3ggcFvZMyGmYRMCwOCawoe gpAQ+qN309taPSWjgdfNie9jpa2l7BpPIJOcJto= X-Google-Smtp-Source: APXvYqzCQJD3tpd6TkfCimOqle3PKCwJoP8VQP2Np60KoCWTaU7lkuGSGgqxSqicoNPYvtjWXsvv7N6VSW5NM9rLroU= X-Received: by 2002:a02:6616:: with SMTP id k22mr2990115jac.129.1568787585766; Tue, 17 Sep 2019 23:19:45 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> In-Reply-To: From: vm finance Date: Tue, 17 Sep 2019 23:19:32 -0700 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net X-Rspamd-Queue-Id: 46Y8w31ZCTz3Nd7 X-Spamd-Bar: +++++++++++ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=MIBeCGBQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d2f as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [11.50 / 15.00]; GREYLIST(0.00)[pass,meta]; R_SPF_ALLOW(0.00)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; URI_COUNT_ODD(1.00)[17]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; NEURAL_SPAM_MEDIUM(1.00)[0.998,0]; BAD_REP_POLICIES(0.10)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(1.00)[1.000,0]; RCVD_IN_DNSWL_NONE(0.00)[f.2.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; URIBL_BLACK(7.50)[osboxes.org.multi.uribl.com]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(0.00)[ip: (-6.04), ipnet: 2607:f8b0::/32(-2.68), asn: 15169(-2.23), country: US(-0.05)] X-Spam: Yes Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 06:19:48 -0000 correcting a typo: svn co svn://svn.freebsd.org/base/head /usr/src current revision: 352434 Thank you! On Tue, Sep 17, 2019 at 10:11 PM vm finance wrote: > Actually I am on head already as mentioned previously. Pulled it using > yesterday: > > svn co svn://svn.freebsd.org/base/head /use/src > > > If you could pls let me know the new patch, I can try that. > > Thanks > > Sent from my iPhone > > On 18-Sep-2019, at 8:56 AM, Randall Stewart wrote: > > There have been several patches pre-this one that provide > the infrastructure to support BBR. > > Release 12.0 will *not* have these patches and will *not* compile it. > > I have no intention at this point in doing a MFC of this work.. so if you > want > to run BBR you need to run Head > > R > > On Sep 17, 2019, at 7:26 PM, vm finance wrote: > > > Hi Randall, > > > Could you please provide a pointer to the latest patch. I had applied the > one you published Sep-10. > > > Following is what I have done: > > 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org > > 2. Got VM up under VMPlayer on x86 laptop > > 3. Checked out latest codebase from freebsd repo: > > svn co svn://svn.freebsd.org/base/head /usr/src* > > cd /usr/src; > > make buildworld buildkernel > > [this is where make fails when patch is applied] > > > I could try to build with your latest patch - please send me a pointer. > > > Thanks for your help! > > > > On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart wrote: > > Looking at your make file log I can=E2=80=99t really tell what you are do= ing. > > > Its not the BBR or Rack code that is blowing up=E2=80=A6 > > > Are you cross compiling? > > > I have done the old fashioned kernel make > > > i.e. > > > cd src/sys/amd64/config > > config headvm > > cd ../compile/headvm > > > make cleandepend ; make depend; make -j3 > > > I have done > > > cd src > > make buildkernel KERNCONF=3Dheadvm > > > And even > > > make buildkernel KERNCONF=3DGENERIC > > > to make sure that the build works without bbr. > > > I attach my headvm config.. > > > What exactly are you building and how? kernel config too please? > > > R > > > > > > On Sep 17, 2019, at 1:11 PM, Randall Stewart wrote: > > > looking > > > I was at 352408.. let me update and try it > > > R > > > On Sep 17, 2019, at 1:10 PM, Randall Stewart wrote: > > > Hmm > > > Did you get the patch I updated too this am? > > > I have built it both with and without the bbr stack and had no issue.. > there was > > an issue with KTLS before the update though. > > > I don=E2=80=99t recognize what you have below there though=E2=80=A6 > > > R > > > On Sep 17, 2019, at 11:47 AM, vm finance wrote: > > > Got it - thank you! > > > btw, I tried to build the patch but its giving an error. Following is SVN > info + make error mesg. > > > Please let me know what am I missing here? > > > Thanks! > > > #svnlite revision > > Path: . > > Working Copy Root Path: /usr/src > > URL: svn://svn.freebsd.org/base/head > > Relative URL: ^/head > > Repository Root: svn://svn.freebsd.org/base > > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > Revision: 352436 > > Node Kind: directory > > Schedule: normal > > Last Changed Author: jah > > Last Changed Rev: 352434 > > Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > > > root@osboxes:/usr/src # > > > -------------------------------------------- snip > ---------------------------- > > > ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo dev_net.llo > bcache.llo interp_simple.llo zfs_cmd.llo > > rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > =3D=3D=3D> sys (cleandir) > > rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o sack_filter.o > rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h > opt_kern_tls.h > > rm: x86: is a directory > > *** Error code 1 > > > Stop. > > make[3]: stopped in /usr/src/sys > > *** Error code 1 > > > Stop. > > make[2]: stopped in /usr/src > > *** Error code 1 > > > Stop. > > make[1]: stopped in /usr/src > > *** Error code 1 > > > Stop. > > make: stopped in /usr/src > > > > On Tue, Sep 17, 2019 at 6:41 PM vm finance wrote: > > Got it - thank you! > > > btw, I tried to build the patch but its giving an error. Following is SVN > info + make error mesg. > > I have also attached the entire build log...snippet is below > > > Please let me know what am I missing here? > > > Thanks! > > > #svnlite revision > > Path: . > > Working Copy Root Path: /usr/src > > URL: svn://svn.freebsd.org/base/head > > Relative URL: ^/head > > Repository Root: svn://svn.freebsd.org/base > > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > Revision: 352436 > > Node Kind: directory > > Schedule: normal > > Last Changed Author: jah > > Last Changed Rev: 352434 > > Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > > > root@osboxes:/usr/src # > > > -------------------------------------------- snip > ---------------------------- > > > ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo dev_net.llo > bcache.llo interp_simple.llo zfs_cmd.llo > > rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > =3D=3D=3D> sys (cleandir) > > rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o sack_filter.o > rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h > opt_kern_tls.h > > rm: x86: is a directory > > *** Error code 1 > > > Stop. > > make[3]: stopped in /usr/src/sys > > *** Error code 1 > > > Stop. > > make[2]: stopped in /usr/src > > *** Error code 1 > > > Stop. > > make[1]: stopped in /usr/src > > *** Error code 1 > > > Stop. > > make: stopped in /usr/src > > > > On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart wrote: > > Pacing is provided by tcp_hpts.c. The current linux patches do not have > > to have fq.. they built an alternate means of doing pacing into bbr. > > > In either case our testing has shown that our pacing is more accurate tha= n > > either fq or the internal pacer :) > > > R > > > On Sep 17, 2019, at 11:05 AM, vm finance wrote: > > > Thanks Randall. > > I was able to apply the patch - now rebuilding the kernel. Would update o= n > how it goes. > > > BTW, is there any description on how lack of tc_fq under FreeBSD is > compensated here? > > The original BBR patches on Linux show that as a must-have? Is that > functionality implemented via tcp_ratelimit.[ch]? > > > Any pointers to existing presentations/discussions highly appreciated? > > > Thanks a lot. > > > On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart wrote: > > You should be able to compile it against the current head. I re-doing tha= t > now (had an > > issue with my machine and had to roll it back to a backup). > > > When I put the patch up on Sept 10th it complied with and without BBR on > whatever > > was that rev.. > > > Looking in the commit logs that would have been around 352191 > > > Hope that helps > > > R > > > On Sep 17, 2019, at 3:32 AM, vm finance wrote: > > > Hi Randall, > > > Thanks for releasing BBR patch: > > https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq > > > Could you please let me know what SVN/GIT label tag this is based on? I > would like to patch and experiment with it. I couldn't find this info in > the released patch. > > > Thanks a lot! > > > On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone wrote: > > rrs@ has just posted the BBR patch to phabricator: > > > https://reviews.freebsd.org/D21582 > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > ------ > Randall Stewart > rrs@netflix.com > > > >