From owner-svn-src-all@freebsd.org Fri Nov 13 23:26:27 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 90567A2EC4B for ; Fri, 13 Nov 2015 23:26:27 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1813119E8 for ; Fri, 13 Nov 2015 23:26:27 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by wmdw130 with SMTP id w130so47969199wmd.0 for ; Fri, 13 Nov 2015 15:26:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay_co_uk.20150623.gappssmtp.com; s=20150623; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=RMo9k0X2EJKgXc+BYreEcSakoWDqXd07L6s4j0i0aBs=; b=PzYwKJv+IGeydT01OmRY9eFHhXOBJq9BwYw71mdHFNrPsqvRArAyBzDOurlL4GMaRz BcRw6AElXfc7V4WMW/92aTxNP9IDKKGSCmqNgTRZrrsh0ACPuW8FLTBZ2/SPUNIWbtkw AKzNoF0saGr1Hz263nWz2s0HsZ16E+zzkj28xDvapqi10tOSzkKuztxUWsemYoeTg6px 52kRuLL5ry7sUe6DjLY4VL2IZoPmBbT483Z1ydvgPHHTR7yy0kQ0u2EEhdkO2RN+/UP0 9Wf0J0ir9M9nWviuGNlMhMfE1GueHG79bO0VIhCnfLd2u67Szk4deJeVjHtCn8svWCpf bMSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=RMo9k0X2EJKgXc+BYreEcSakoWDqXd07L6s4j0i0aBs=; b=QoOR7pozZ3hgwLo28TE7mFOfIKpQtChwHIgNQ/Cvp/JJyGKjZUfMyVtM7x6ZAA/khX 3xTemdAiSH9dK36+eu/UzMisuKGqnMH9ZsnZlIjEYfzgvKQn7QhnqW0BGxA0IlzSopy5 DZT8saXitCMj+A+ghouTASrzooFuqijSfPmsRPB4HPPlf+DUP/mJxGvo5eIh1hmOyTbN KtHM0KvfCGzy1/XCSAnS3N2waMSVptPJxMT/0brS7rl53tCxegD68eQGopFJucnNOCRo rwA550un23oxhNaXlnchB8D3MkO6sowIL9/dDvadPUI8Ol8AwzbHhjso3A1CmdbilwLx UDew== X-Gm-Message-State: ALoCoQmxiMix++c5waMOZgNtF9WJM78LNSiJXnN+c4kHcpL5dd+A/ERp/omPUpbhe55U2cb7l9xL X-Received: by 10.28.150.11 with SMTP id y11mr6052448wmd.43.1447457185546; Fri, 13 Nov 2015 15:26:25 -0800 (PST) Received: from [10.10.1.58] (liv3d.labs.multiplay.co.uk. [82.69.141.171]) by smtp.gmail.com with ESMTPSA id l1sm6097719wmg.21.2015.11.13.15.26.24 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 13 Nov 2015 15:26:24 -0800 (PST) From: Steven Hartland X-Google-Original-From: Steven Hartland Subject: Re: svn commit: r290450 - in head: sbin/ifconfig share/man/man4 sys/net To: Gleb Smirnoff References: <201511061533.tA6FXSmq054394@repo.freebsd.org> <20151113223627.GC73031@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <564671AE.1030405@freebsd.org> Date: Fri, 13 Nov 2015 23:26:38 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151113223627.GC73031@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2015 23:26:27 -0000 On 13/11/2015 22:36, Gleb Smirnoff wrote: > On Fri, Nov 06, 2015 at 03:33:28PM +0000, Steven Hartland wrote: > S> Author: smh > S> Date: Fri Nov 6 15:33:27 2015 > S> New Revision: 290450 > S> URL: https://svnweb.freebsd.org/changeset/base/290450 > S> > S> Log: > S> Add sysctl to control LACP strict compliance default > S> > S> Add net.link.lagg.lacp.default_strict_mode which defines > S> the default value for LACP strict compliance for created > S> lagg devices. > S> > S> Also: > S> * Add lacp_strict option to ifconfig(8). > S> * Fix lagg(4) creation examples. > S> * Minor style(9) fix. > > AFAIU, you are adding the sysctl to close a very short period > of time between cloning a lagg(4) and configuring it. > > This is not a pretty solution to the problem. But the network > stack has an API for supplying extra parameters at the cloning > time. The lagg_clone_create() accepts the params, that can > be supplied by ifconfig. If you put there the same arguments you > supply with SIOCGLAGGOPTS, you can create and configure a lagg > in one syscall. > In our case strict mode totally breaks for us on some old switches, the only option to restore functionality was to disable it so we use this loader.conf to ensure sysadmins don't mess up when creating new lagg's. So yes we could do that as well but it wouldn't fix the issue we're using the sysctl for. Regards Steve