From owner-cvs-all@FreeBSD.ORG Sat Apr 10 01:06:41 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3B6A516A4CE; Sat, 10 Apr 2004 01:06:41 -0700 (PDT) Received: from arginine.spc.org (arginine.spc.org [195.206.69.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 76F6343D31; Sat, 10 Apr 2004 01:06:40 -0700 (PDT) (envelope-from bms@spc.org) Received: from localhost (localhost [127.0.0.1]) by arginine.spc.org (Postfix) with ESMTP id 9D193653DF; Sat, 10 Apr 2004 09:06:38 +0100 (BST) Received: from arginine.spc.org ([127.0.0.1]) by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 86412-02-2; Sat, 10 Apr 2004 09:06:38 +0100 (BST) Received: from empiric.dek.spc.org (82-147-17-88.dsl.uk.rapidplay.com [82.147.17.88]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by arginine.spc.org (Postfix) with ESMTP id 249B9653B5; Sat, 10 Apr 2004 09:06:38 +0100 (BST) Received: by empiric.dek.spc.org (Postfix, from userid 1001) id 6CA1060EE; Sat, 10 Apr 2004 09:06:37 +0100 (BST) Date: Sat, 10 Apr 2004 09:06:37 +0100 From: Bruce M Simpson To: Maxime Henrion Message-ID: <20040410080636.GP710@empiric.dek.spc.org> Mail-Followup-To: Maxime Henrion , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200404091427.i39ERSWC044630@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200404091427.i39ERSWC044630@repoman.freebsd.org> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/arp Makefile arp.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Apr 2004 08:06:41 -0000 On Fri, Apr 09, 2004 at 07:27:28AM -0700, Maxime Henrion wrote: > Log: > - Change several errx() calls that should have been err() calls. > - Handle empty ARP tables properly. Thank god for that. Personally I think the error message 'actual retrieval of routing table' when the ARP table(s) are empty is a bug as it implies there was a problem when there wasn't one. Can the two conditions be told apart? If so, let's change it... Just a drive-by 2c, BMS