Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 Jan 2019 00:52:41 +0000 (UTC)
From:      Oleksandr Tymoshenko <gonzo@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r343029 - head/sys/dev/led
Message-ID:  <201901150052.x0F0qfLk020567@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: gonzo
Date: Tue Jan 15 00:52:41 2019
New Revision: 343029
URL: https://svnweb.freebsd.org/changeset/base/343029

Log:
  [led] propagate error from set_led() to the caller
  
  Do not lose error condition by always returning 0 from set_led.
  None of the calls to set_led checks for return value at the moment so
  none of API consumers in base is affected.
  
  PR:		231567
  Submitted by:	Bertrand Petit <bsdpr@phoe.frmug.org>
  MFC after:	1 week

Modified:
  head/sys/dev/led/led.c

Modified: head/sys/dev/led/led.c
==============================================================================
--- head/sys/dev/led/led.c	Tue Jan 15 00:37:37 2019	(r343028)
+++ head/sys/dev/led/led.c	Tue Jan 15 00:52:41 2019	(r343029)
@@ -261,7 +261,7 @@ led_set(char const *name, char const *cmd)
 	mtx_unlock(&led_mtx);
 	if (sb != NULL)
 		sbuf_delete(sb);
-	return (0);
+	return (error);
 }
 
 static struct cdevsw led_cdevsw = {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201901150052.x0F0qfLk020567>