From owner-dev-commits-src-all@freebsd.org  Mon Apr 26 16:49:33 2021
Return-Path: <owner-dev-commits-src-all@freebsd.org>
Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id E10E95E759E;
 Mon, 26 Apr 2021 16:49:33 +0000 (UTC) (envelope-from nc@freebsd.org)
Received: from rainpuddle.neelc.org (rainpuddle.neelc.org
 [IPv6:2001:19f0:8001:fed:5400:2ff:fe73:c622])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4FTW8F5Zjtz3qlt;
 Mon, 26 Apr 2021 16:49:33 +0000 (UTC) (envelope-from nc@freebsd.org)
Received: from mail.neelc.org (rainpuddle.neelc.org
 [IPv6:2001:19f0:8001:fed:5400:2ff:fe73:c622])
 by rainpuddle.neelc.org (Postfix) with ESMTPSA id 1DA40EB2A5;
 Mon, 26 Apr 2021 09:49:26 -0700 (PDT)
MIME-Version: 1.0
Date: Mon, 26 Apr 2021 09:49:25 -0700
From: Neel Chauhan <nc@freebsd.org>
To: John Baldwin <jhb@freebsd.org>
Cc: Shawn Webb <shawn.webb@hardenedbsd.org>, src-committers@freebsd.org,
 dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org
Subject: Re: git: 9db8b85a942d - stable/13 - linuxkpi: Remove unneeded {} in
 atomic_dec_and_lock_irqsave()
In-Reply-To: <67e6aa7a-3c1d-1055-d468-b6a366382f04@FreeBSD.org>
References: <202104261545.13QFjAYB012989@gitrepo.freebsd.org>
 <20210426160242.7nddbshrccusdb5j@mutt-hbsd>
 <67e6aa7a-3c1d-1055-d468-b6a366382f04@FreeBSD.org>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <fe200346753753dd6978636a2299417c@freebsd.org>
X-Sender: nc@freebsd.org
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 4FTW8F5Zjtz3qlt
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the src repository
 <dev-commits-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-all/>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Help: <mailto:dev-commits-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Apr 2021 16:49:33 -0000

On 2021-04-26 09:42, John Baldwin wrote:
> I agree.  20 minutes is far too short.  The normal minimum is 3 days.
> You already have feedback on the commits to main that you should
> probably adjust before merging (specifically Mateusz's quite salient 
> point).
> Requiring two immediate fixups to the original commit in main is also
> indicative that the change in question isn't really ready yet.

Sorry about this. I'm new(-ish?) to src.

The immediate "fixups" are just formatting changes that were requested, 
not really bugfixes.

-Neel