From owner-freebsd-audit  Sat Jan 13  5:29:15 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65])
	by hub.freebsd.org (Postfix) with ESMTP id D62DA37B400
	for <freebsd-audit@FreeBSD.ORG>; Sat, 13 Jan 2001 05:28:54 -0800 (PST)
Received: from grondar.za (root@gratis.grondar.za [196.7.18.133])
	by gratis.grondar.za (8.11.1/8.11.1) with ESMTP id f0DDRYI20099;
	Sat, 13 Jan 2001 15:27:36 +0200 (SAST)
	(envelope-from mark@grondar.za)
Message-Id: <200101131327.f0DDRYI20099@gratis.grondar.za>
To: Chris Faulhaber <jedgar@fxp.org>
Cc: freebsd-audit@FreeBSD.ORG
Subject: Re: temp dirs in Makefile.inc1 
References: <20010111101813.A76735@peitho.fxp.org> 
In-Reply-To: <20010111101813.A76735@peitho.fxp.org> ; from Chris Faulhaber <jedgar@fxp.org>  "Thu, 11 Jan 2001 10:18:13 EST."
Date: Sat, 13 Jan 2001 15:27:27 +0200
From: Mark Murray <mark@grondar.za>
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


Looks good to me!

M

> Currently for an installworld, Makefile.inc1 defines the temporary
> directory used as:
> 
> TMPDIR?=	/tmp
> TMPPID!=	echo $$$$
> INSTALLTMP=	${TMPDIR}/install.${TMPPID}
> 
> I submitted a patch to marcel (who did not object) to use mktemp(1)
> for a more secure directory name.  However, I wanted to run it by
> -audit before committing...  Personally, I have been running with
> this patch on -current for over a month without problems.
> 
> -- 
> Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org
> --------------------------------------------------------
> FreeBSD: The Power To Serve   -   http://www.FreeBSD.org
> 
> Index: Makefile.inc1
> ===================================================================
> RCS file: /home/ncvs/src/Makefile.inc1,v
> retrieving revision 1.180
> diff -u -r1.180 Makefile.inc1
> --- Makefile.inc1	2000/12/24 14:58:34	1.180
> +++ Makefile.inc1	2001/01/11 15:15:01
> @@ -130,9 +130,7 @@
>  STRICTTMPPATH=	${WORLDTMP}/usr/sbin:${WORLDTMP}/usr/bin:${WORLDTMP}/usr/games
>  TMPPATH=	${STRICTTMPPATH}:${PATH}
>  
> -TMPDIR?=	/tmp
> -TMPPID!=	echo $$$$
> -INSTALLTMP=	${TMPDIR}/install.${TMPPID}
> +INSTALLTMP!=	mktemp -d -t install
>  
>  #
>  # Building a world goes through the following stages
> @@ -295,7 +293,6 @@
>  # Installs everything compiled by a 'buildworld'.
>  #
>  installworld:
> -	mkdir -p ${INSTALLTMP}
>  	for prog in [ awk cat chflags chmod chown date echo egrep find grep \
>  	    install ln make makewhatis mtree mv perl rm sed sh sysctl \
>  	    test true uname wc zic; do \
> 
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-audit" in the body of the message
> 
-- 
Mark Murray
Warning: this .sig is umop ap!sdn


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message