From owner-svn-src-head@FreeBSD.ORG Mon Nov 4 21:43:59 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A2ABD4DA; Mon, 4 Nov 2013 21:43:59 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5DD1F2565; Mon, 4 Nov 2013 21:43:59 +0000 (UTC) Received: from [192.168.0.15] (coleburn.home.andric.com [192.168.0.15]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 8D3305C43; Mon, 4 Nov 2013 22:43:50 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_4A5DE038-66FC-4E09-99F7-83E95AABDF46"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1816\)) Subject: Re: svn commit: r257645 - head/gnu/lib/libgcc From: Dimitry Andric In-Reply-To: <201311041815.rA4IFjwO081492@svn.freebsd.org> Date: Mon, 4 Nov 2013 22:43:40 +0100 Message-Id: <57710455-9B81-47FF-926B-1075EB6F4290@FreeBSD.org> References: <201311041815.rA4IFjwO081492@svn.freebsd.org> To: Sean Bruno X-Mailer: Apple Mail (2.1816) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Nov 2013 21:43:59 -0000 --Apple-Mail=_4A5DE038-66FC-4E09-99F7-83E95AABDF46 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 04 Nov 2013, at 19:15, Sean Bruno wrote: > Author: sbruno > Date: Mon Nov 4 18:15:45 2013 > New Revision: 257645 > URL: http://svnweb.freebsd.org/changeset/base/257645 >=20 > Log: > Quiesce warning around gcc_assert() for an inline macro that uses > a static variable. This code has been moved around in gcc, but is = still in > use in the latest trunk version of the compiler. >=20 > gnu/lib/libgcc/../../../contrib/gcc/unwind-dw2.c:208:36: > warning: static variable 'dwarf_reg_size_table' is used in an = inline > function with external linkage [-Wstatic-in-inline] > gcc_assert (index < (int) sizeof(dwarf_reg_size_table)); The warning is actually correct, since _Unwind_SetGR() is an extern inline function (although it is not explicitly declared as such), but it does access a static variable. It would probably be safest to make the variable non-static instead, since the function itself cannot be changed to static inline. -Dimitry --Apple-Mail=_4A5DE038-66FC-4E09-99F7-83E95AABDF46 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iEYEARECAAYFAlJ4FRMACgkQsF6jCi4glqO4igCg9Vr9wCaeelvd6UebQQi8eBbM 3sEAn3lkNntcFJC6TROOsK2f+eANUvcB =w4Rn -----END PGP SIGNATURE----- --Apple-Mail=_4A5DE038-66FC-4E09-99F7-83E95AABDF46--