From owner-dev-commits-src-main@freebsd.org Tue Apr 27 00:16:14 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A78DF5F5800 for ; Tue, 27 Apr 2021 00:16:14 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FTj3f454Dz4kQY for ; Tue, 27 Apr 2021 00:16:14 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: by mail-yb1-xb2c.google.com with SMTP id c195so67136147ybf.9 for ; Mon, 26 Apr 2021 17:16:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=0AyoT9c6dAg2mTff27/Cw7SGcDltvRuduSv/vyknP5c=; b=KF2z7HkqzC0ieMwDyKxVn+TjQLX/FYMkAnOBRG2itE/1G1NqZmnHJwOdgoa8OjAdGc 5x6HFwJOWJcuA4iBwIvudB2Ta+zRCAhSDhe+TxjMbIoz2Jx1pEg59Ea8o3FwW4Z/uhow i029UBgf0thtwcGeql8Tes5pggZrOk4tN2ook= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0AyoT9c6dAg2mTff27/Cw7SGcDltvRuduSv/vyknP5c=; b=l1aLM64U5li02SbIqCms5gLHvgojS5Avrww9hRxRPHgPsSEottw/igpBrxx/w0Yr6W ibEjoQ1Fpluc2ikLuZuxVwjXfgFD+N1cT0bqbeN78Pn9KHtBeaKXZwHjR/M8/RH68ANk sdig8hFZagRJSuzaBeRrxKUb5NEv6xnUwmIxN8wJPiaZxero+WUHa71OcVT9eHvXeD68 SRWzbmtkPczEaI0ywZES68FEV6+vFMu9CoIkGFAo+bp/VDwEVlujUQpp+2sCRblTXlUv 91fuHBaYLZqS+5JTm7Lh/YWBRQBfKCYyXpiygGHAi5XyomQ8nqiYCO+Mz4ZfS50wWV5p ym7Q== X-Gm-Message-State: AOAM530HxZzXm1saLwL+Asm6DugMEAzf9ptV8Z3YvpjKVQ3IDb2hGxGw VnKRqJRXyMFV73M63UIzzKJcWANk+owYLEQUqqQKDg== X-Google-Smtp-Source: ABdhPJxqzpuAiiowJbkm4wut/nAQHOHj73ElTYtE4eGiOoLSB+tS+TjNxG96s2m1wldvWW95J/nMTjQw/MUJvYkEkUM= X-Received: by 2002:a25:680c:: with SMTP id d12mr27131591ybc.87.1619482573294; Mon, 26 Apr 2021 17:16:13 -0700 (PDT) MIME-Version: 1.0 References: <202104261525.13QFPrbg086311@gitrepo.freebsd.org> <9b006e97a64d01d128d81bc09f0891ea@freebsd.org> In-Reply-To: From: Kevin Bowling Date: Mon, 26 Apr 2021 17:16:01 -0700 Message-ID: Subject: Re: git: e657f3de6dc2 - main - linuxkpi: Remove unneeded {} in atomic_dec_and_lock_irqsave() To: Rick Macklem Cc: Neel Chauhan , src-committers , "dev-commits-src-all@FreeBSD.org" , "dev-commits-src-main@FreeBSD.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4FTj3f454Dz4kQY X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2021 00:16:14 -0000 Yup, I don't want to fatigue Neel or the tree with unnecessary churn, he had the parens, someone said something about brackets {} and he removed the parens. Since the function needs a rework per mjg's review, it could be done when that occurs. On Mon, Apr 26, 2021 at 3:29 PM Rick Macklem wrote: > > Neel wrote: > >On 2021-04-26 09:47, Kevin Bowling wrote: > >> I'm not sure all the context or conversation here but the convention > >> is to not use bare return values, i.e in style(9) "Values in return > >> statements should be enclosed in parentheses." and that's what was > >> asked to be changed on this mailing list. > Just fyi to everyone, there is this in style(9): > In general code can be considered =E2=80=9Cnew code=E2=80=9D when it= makes up about 50% > or more of the file(s) involved. This is enough to break precedents= in > the existing code and use the current style guidelines. > > As such, if the "return 0;" predates this patch series, Neel is correct > to use "return 1;", since that precedent has already been established. > I'll admit I see the above ignored a lot and personally don't care if > the above generality is followed, but it is in style(9) and I do > think a consistent style is preferred over a jumble within a source file. > > rick > > The review: https://reviews.freebsd.org/D29988 > > I believe I was asked to do this in the review. > > -Neel > > > > Can you use and link to Phabricator for your src commits? As much as > > possible it is preferable to get it right in one go, for MFCs, > > bisection, etc and this kind of churn should be preventable with quick > > reviews. Feel free to tag me as a reviewer. > > Sure, will do next time. > > > > Regards, > > Kevin > > -Neel >