From owner-svn-ports-all@freebsd.org Thu May 10 23:00:47 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8EA8BFD9DA6; Thu, 10 May 2018 23:00:47 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4086D7B937; Thu, 10 May 2018 23:00:47 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 21D7126D3E; Thu, 10 May 2018 23:00:47 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w4AN0lLB083724; Thu, 10 May 2018 23:00:47 GMT (envelope-from bdrewery@FreeBSD.org) Received: (from bdrewery@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w4AN0lCH083723; Thu, 10 May 2018 23:00:47 GMT (envelope-from bdrewery@FreeBSD.org) Message-Id: <201805102300.w4AN0lCH083723@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: bdrewery set sender to bdrewery@FreeBSD.org using -f From: Bryan Drewery Date: Thu, 10 May 2018 23:00:47 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-branches@freebsd.org Subject: svn commit: r469590 - branches/2018Q2/Mk/Scripts X-SVN-Group: ports-branches X-SVN-Commit-Author: bdrewery X-SVN-Commit-Paths: branches/2018Q2/Mk/Scripts X-SVN-Commit-Revision: 469590 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 23:00:47 -0000 Author: bdrewery Date: Thu May 10 23:00:46 2018 New Revision: 469590 URL: https://svnweb.freebsd.org/changeset/ports/469590 Log: MFH: r469589 stage-qa: Change stripped check to only look for .debug_info. 'strip -x', and splitting out debug symbols with objcopy, will leave a .symtab section but will still remove the .debug_info section. file(1) shows this distinction as well after the use of 'strip -x': work/tcl8.7a1/unix/libtcl8.7.so: ELF 64-bit LSB shared object, x86-64, version 1 (FreeBSD), dynamically linked, with debug_info, not stripped work/stage/usr/local/lib/libtcl8.7.so: ELF 64-bit LSB shared object, x86-64, version 1 (FreeBSD), dynamically linked, not stripped This fixes false-positives when using install-strip and symbol splitting. With hat: portmgr Approved by: portmgr (implicit) Modified: branches/2018Q2/Mk/Scripts/qa.sh Directory Properties: branches/2018Q2/ (props changed) Modified: branches/2018Q2/Mk/Scripts/qa.sh ============================================================================== --- branches/2018Q2/Mk/Scripts/qa.sh Thu May 10 23:00:15 2018 (r469589) +++ branches/2018Q2/Mk/Scripts/qa.sh Thu May 10 23:00:46 2018 (r469590) @@ -210,7 +210,7 @@ stripped() { find ${STAGEDIR} -type f ! -name '*.a' ! -name '*.o' \ -exec readelf -S {} + 2>/dev/null | awk '\ /File:/ {sub(/File: /, "", $0); file=$0} \ - /SYMTAB/ {print file}' | + /[[:space:]]\.debug_info[[:space:]]*PROGBITS/ {print file}' | while read f; do warn "'${f#${STAGEDIR}${PREFIX}/}' is not stripped consider trying INSTALL_TARGET=install-strip or using \${STRIP_CMD}" done