From owner-svn-src-all@FreeBSD.ORG Mon Jul 13 20:34:16 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1205) id 6EB86106566B; Mon, 13 Jul 2009 20:34:16 +0000 (UTC) Date: Mon, 13 Jul 2009 20:34:16 +0000 From: Navdeep Parhar To: Lawrence Stewart Message-ID: <20090713203416.GA2976@hub.freebsd.org> Mail-Followup-To: Lawrence Stewart , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <200907131151.n6DBp35J024156@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200907131151.n6DBp35J024156@svn.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r195654 - in head: . sys/dev/cxgb/ulp/tom sys/netinet sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2009 20:34:16 -0000 On Mon, Jul 13, 2009 at 11:51:03AM +0000, Lawrence Stewart wrote: > Author: lstewart > Date: Mon Jul 13 11:51:02 2009 > New Revision: 195654 > URL: http://svn.freebsd.org/changeset/base/195654 > > Log: > Replace struct tcpopt with a proxy toeopt struct in the TOE driver interface to > the TCP syncache. This returns struct tcpopt to being private within the TCP > implementation, thus allowing it to be modified without ABI concerns. > > The patch breaks the ABI. Bump __FreeBSD_version to 800103 accordingly. The cxgb > driver is the only TOE consumer affected by this change, and needs to be > recompiled along with the kernel. > > Suggested by: rwatson > Reviewed by: rwatson, kmacy > Approved by: re (kensmith), kensmith (mentor temporarily unavailable) > Hello Lawrence, 'to' should be renamed to 'toeo' in syncache_expand_establish_req() before the changes you made to cxgb_cpl_io.c will even compile. - struct toeopt to; + struct toeopt toeo; Unfortunately, cxgb's TOM is commented out of the build system (ever since ARPv2) and so buildkernel won't catch stuff like this. I have a tree that builds TOM with the latest head but it won't be ready+tested in time for 8.0. Regards, Navdeep > Modified: > head/UPDATING > head/sys/dev/cxgb/ulp/tom/cxgb_cpl_io.c > head/sys/netinet/tcp_offload.h > head/sys/netinet/tcp_syncache.c > head/sys/netinet/tcp_syncache.h > head/sys/netinet/tcp_var.h > head/sys/sys/param.h