From nobody Fri Jan 30 00:03:06 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f2GS02Fqrz6QKBG for ; Fri, 30 Jan 2026 00:03:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f2GS00Qmyz3HMX for ; Fri, 30 Jan 2026 00:03:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769731392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZrIY3qk+ea/lxc3L88rbPiX+Z0gXQLckml/pKJL2grM=; b=eQsZzSk84NJRMV6jRjy/ZKoIp4Iori63YwQBqVYYRV7fgvM94WBGuEjio6s1MEWrxss0gb Mg3UvCuFq3LXA+1b/Q1xaCZliTXHv9n5/fNrrmhbsZT47B5s4IcrLJK3LO5bA26iytadzj Zx4HkyTlyEpXLQzvWG9STmzn9mwrXYuQycMY2r16vdJc66Gw8XkSSn7g2aX2WUGKtI/csG Z7ed8IPkug+22kQhAEj4SuvFKPtK0gxOjgOYZ8jeyiATc8DoUsGhKpdUmtkDeNo9mIoLAq wXLpCNE0tacvXjW6Z0KN2vLwrurUlps3NL5LlVnfiUTzpUJlyfajDGR6P5uSwQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769731392; a=rsa-sha256; cv=none; b=LsN+QcYTO/A5vf3jQOcDuenLLZm3PKEic9wVETQ+TmOKWCln+xu1092sKNxGl3pCFo0qOk w7hxnDQPEHieRL0LQHN4fV5mxQ2ABghcgzzIs05fpEL1mkQWxn74g5De2h5M8eeRS2mxlI TlrgfYgfRE57OtgjFHYPdsGn9JCAWs52Xx1h1GRQNv7GaTufPVGEIj3S05a3/iWI8g4PFK u5U0ToQUFCrmq5YUMIW8usJMg+/JAF7ioVsDUIe9sxgvQwNB0ZzYcczbyT3fSCaaJDvDz6 KhdlqU61GslPCH4nAgUTe7/zIxxGYDPtLHh8yxQ0VrWyxRYLF7UDMWgPErXneQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769731392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZrIY3qk+ea/lxc3L88rbPiX+Z0gXQLckml/pKJL2grM=; b=laVzNKPIPI0HTV0uGFQz24HtPK6E8mPwBmiMmjtWQ+AsDko4xWHpic0DX4P0LV8zs5RU0d fbPMZrL74Hbw/LM24ZQ51yw1hjwCly7MhXsUN+F+0wUwnls0tBdwidjzF6467K42YUBGMU cLKdTp5wCkk28YE/D5OwRmxUVLQE23lqP1ZE8hu3E3+pRTGyDDtaALDQWJHXyVUI2/5hUM fM0txm0zc4YOj0HladlSWqo2Av/KDrp2qzHkPGRfMtESStk4KnEnQ5gVPLTsR+b9DOzHH0 v0hQV1rsyAtiiATnO6i23ZI7hJg40dBg9RrfUYz9M4uAhCdaAMStpuom9kBX8g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f2GS0028hz10Ln for ; Fri, 30 Jan 2026 00:03:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 9d57 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 30 Jan 2026 00:03:06 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Abdelkader Boudih From: Kyle Evans Subject: git: fdcd67be8274 - main - firmware: Fix inverted FIRMWARE_GET_NOWARN logic List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fdcd67be8274d237ae2c87d6475d9d34b440b8d8 Auto-Submitted: auto-generated Date: Fri, 30 Jan 2026 00:03:06 +0000 Message-Id: <697bf53a.9d57.6d4deeb4@gitrepo.freebsd.org> The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=fdcd67be8274d237ae2c87d6475d9d34b440b8d8 commit fdcd67be8274d237ae2c87d6475d9d34b440b8d8 Author: Abdelkader Boudih AuthorDate: 2026-01-30 00:02:47 +0000 Commit: Kyle Evans CommitDate: 2026-01-30 00:02:47 +0000 firmware: Fix inverted FIRMWARE_GET_NOWARN logic The try_binary_file() function has inverted logic for the FIRMWARE_GET_NOWARN flag. When the flag is set (meaning "don't warn"), the code sets warn=true and makes noise anyway. Invert the assignment to warn to correctly suppress warnings when FIRMWARE_GET_NOWARN is set. Reviewed by: kevans Differential Revision: https://reviews.freebsd.org/D54955 --- sys/kern/subr_firmware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/subr_firmware.c b/sys/kern/subr_firmware.c index d616339f2c07..88b2e71ba8df 100644 --- a/sys/kern/subr_firmware.c +++ b/sys/kern/subr_firmware.c @@ -281,7 +281,7 @@ try_binary_file(const char *imagename, uint32_t flags) int oflags; size_t resid; int error; - bool warn = flags & FIRMWARE_GET_NOWARN; + bool warn = (flags & FIRMWARE_GET_NOWARN) == 0; /* * XXX TODO: Loop over some path instead of a single element path.