From owner-svn-src-head@FreeBSD.ORG  Tue Jun 30 14:49:04 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E8E37106564A;
	Tue, 30 Jun 2009 14:49:04 +0000 (UTC)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
	[128.208.78.105])
	by mx1.freebsd.org (Postfix) with ESMTP id C622D8FC16;
	Tue, 30 Jun 2009 14:49:04 +0000 (UTC)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu
	[127.0.0.1])
	by troutmask.apl.washington.edu (8.14.3/8.14.3) with ESMTP id
	n5UEn4w5042019; Tue, 30 Jun 2009 07:49:04 -0700 (PDT)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)
	by troutmask.apl.washington.edu (8.14.3/8.14.3/Submit) id
	n5UEn4aB042018; Tue, 30 Jun 2009 07:49:04 -0700 (PDT)
	(envelope-from sgk)
Date: Tue, 30 Jun 2009 07:49:04 -0700
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: bz0fbd@zabbadoz.net
Message-ID: <20090630144904.GA41936@troutmask.apl.washington.edu>
References: <200906300318.n5U3Ipr4066645@svn.freebsd.org>
	<20090630051641.T22887@maildrop.int.zabbadoz.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090630051641.T22887@maildrop.int.zabbadoz.net>
User-Agent: Mutt/1.4.2.3i
Cc: svn-src-head@freebsd.org, dfr@freebsd.org, src-committers@freebsd.org,
	svn-src-all@freebsd.org, John Baldwin <jhb@freebsd.org>
Subject: Re: svn commit: r195181 - in head/sys: nfsclient nfsserver
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Jun 2009 14:49:05 -0000

On Tue, Jun 30, 2009 at 05:17:48AM +0000, bz0fbd@zabbadoz.net wrote:
> On Tue, 30 Jun 2009, John Baldwin wrote:
> 
> >Author: jhb
> >Date: Tue Jun 30 03:18:51 2009
> >New Revision: 195181
> >URL: http://svn.freebsd.org/changeset/base/195181
> >
> >Log:
> > Fix build with NFS_LEGACYRPC enabled after the socket upcall locking
> > changes.
> 
> is this really a good idea, considering that NFS_LEGACYRPC is on the
> "removal list" for 8.0?

Yes.

1) This option definitely worked on April 18th.
2) The option was broken by a commit that was never tested!  If anything
   this should remind committers to either get a code review or test
   their patch.

> 
> Will it go or will it stay?  I thought it was already (partly) gone?
> 

Well, as of June 1, this option was technically gone due to a ill-formed
patch.

-- 
Steve