From owner-svn-src-all@freebsd.org Sat May 19 15:49:00 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 530FDEB1327 for ; Sat, 19 May 2018 15:49:00 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D817B73C75 for ; Sat, 19 May 2018 15:48:59 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x244.google.com with SMTP id p124-v6so9709561iod.1 for ; Sat, 19 May 2018 08:48:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=XTjCy0Z/Y7PJhYhPvWcFGTRItzOSPWLo6xakY7gyOqQ=; b=gwKgtgOuplFRKXA4RxGvrtyYQyjkf4RY9zsmEbE8usQtfNF4C0J+N6HZUQHeJRKc1d pJzpuBb9ABZQKz+lE7WdYpfflCrWQHhVdSGeRJJHmaett6CHxi30luk+a2fhmqI/fmXO 4huXroWd7bGzd/EAoXlwdMDHXW+yrL6VlnJpvPO7HeQa1ywHqziNyRVoLWrT9x0V/O/P amVVM95PozUKAcnRcEyMwIltBzmvv0Y4mbEmw8Yu05YsJWCBJuHy4g4hFcApYQgeq5jV h5vylc8NjSFDCHXy4SsUMENj+1GkaZfd02imP2xyVxGqD1LDMffa0ZBmw5BBnsU+LsL6 biWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=XTjCy0Z/Y7PJhYhPvWcFGTRItzOSPWLo6xakY7gyOqQ=; b=BfAJzWCX/vP286hnGkYCDxFVojzKOhSUxWEduyoEZEulXdjARRQC+oeb88SZORknnP 2A9Dt97E9efatKqR/+boMxDX17z9CxQyn2ZM6ecOINnbecc2sjyuLv3tgt0wriyEEGd6 xfTVCthW0nss3G8w9EDJYDL6Raz6TMt3RkttTLJ+yy5bqs/iENET6d+QqfxcCW+f54+n Cj5eexiIMfOAeOo1PvR9Jevu9FxH3aqinVG8O5b6XnNU4FxZ5sZEgZNMpFyjdbZzdX9K UFO8wsg3kTUHxM9DEJi0O0Phh6GU60XZ3cFMSbu0I1+A1oE+867VJWp0wfLNnbXTIulT 9dWg== X-Gm-Message-State: ALKqPwfGaPIy855L2RTRJitEaYVmzXpArRArvtMgGqI8WkEJAb4gVLSA a+kruunITryrvZezKw+wqAYE9L9DCiFZxKASyWLZlg== X-Google-Smtp-Source: AB8JxZr7h7YmPdXhs0tljag6qR+R1bKvwsnxg8h5Yob2mqQ31iFTEXfvX2fLpYjQGCCrITKf9ERgKwiqkBFvDBzQ9/g= X-Received: by 2002:a6b:3846:: with SMTP id f67-v6mr14902294ioa.117.1526744938767; Sat, 19 May 2018 08:48:58 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:a649:0:0:0:0:0 with HTTP; Sat, 19 May 2018 08:48:57 -0700 (PDT) X-Originating-IP: [172.58.56.82] In-Reply-To: References: <201805191335.w4JDZq9b015979@pdx.rh.CN85.dnsmgr.net> <29252c55ea65fe53b9ab4e673ec6726c@megadrive.org> From: Warner Losh Date: Sat, 19 May 2018 09:48:57 -0600 X-Google-Sender-Auth: ujD2yIzbSzitEP9A8hLteu5bVxY Message-ID: Subject: Re: svn commit: r333822 - head/sys/kern To: Matthew Macy Cc: Emmanuel Vadot , owner-src-committers@freebsd.org, "Rodney W. Grimes" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 May 2018 15:49:00 -0000 On Sat, May 19, 2018 at 9:39 AM, Matthew Macy wrote: > > On Sat, May 19, 2018 at 07:17 Emmanuel Vadot > wrote: > >> On 2018-05-19 15:35, Rodney W. Grimes wrote: >> > [ Charset UTF-8 unsupported, converting... ] >> >> Author: mmacy >> >> Date: Sat May 19 02:15:40 2018 >> >> New Revision: 333822 >> >> URL: https://svnweb.freebsd.org/changeset/base/333822 >> >> >> >> Log: >> >> fix gcc8 unused variable and set but not used variable in unix >> >> sockets >> >> add copyright from lock rewrite while here >> >> >> >> Modified: >> >> head/sys/kern/uipc_usrreq.c >> >> >> >> Modified: head/sys/kern/uipc_usrreq.c >> >> ============================================================ >> ================== >> >> --- head/sys/kern/uipc_usrreq.c Sat May 19 00:47:24 2018 >> (r333821) >> >> +++ head/sys/kern/uipc_usrreq.c Sat May 19 02:15:40 2018 >> (r333822) >> >> @@ -4,7 +4,7 @@ >> >> * Copyright (c) 1982, 1986, 1989, 1991, 1993 >> >> * The Regents of the University of California. >> >> * Copyright (c) 2004-2009 Robert N. M. Watson >> >> - * All rights reserved. >> > >> > Did you have permission from Robert Watson to remove this? >> > >> >> + * Copyright (c) 2018 Matthew Macy >> >> * >> >> * Redistribution and use in source and binary forms, with or without >> >> * modification, are permitted provided that the following conditions >> > ... >> >> That also seems a small patch to add your name in the copyright. >> > > Uhh... Locking rewrite was a small patch? Really? > This specific change was trivial. However, rewriting the locking here was non-trivial. The normal rule of thumb is about 25%, but that's flexible. mmacy is responsible for about 14% of the file according to git blame (a number that would be closer to 20% if you omitted the boilerplate parts of the file). If all his changes were trivial variable initializations, then I'd agree this fall short. But the new locking stuff is substantial enough to meet our traditional requirements for adding a copyright line. It affects the majority of the files and is a core functional feature of this file. Warner