From owner-p4-projects@FreeBSD.ORG  Mon Jul  4 16:32:43 2005
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 028A016A420; Mon,  4 Jul 2005 16:32:43 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C938D16A41C
	for <perforce@freebsd.org>; Mon,  4 Jul 2005 16:32:42 +0000 (GMT)
	(envelope-from csjp@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B65F443D55
	for <perforce@freebsd.org>; Mon,  4 Jul 2005 16:32:42 +0000 (GMT)
	(envelope-from csjp@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j64GWgiL090955
	for <perforce@freebsd.org>; Mon, 4 Jul 2005 16:32:42 GMT
	(envelope-from csjp@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j64GWg5g090952
	for perforce@freebsd.org; Mon, 4 Jul 2005 16:32:42 GMT
	(envelope-from csjp@freebsd.org)
Date: Mon, 4 Jul 2005 16:32:42 GMT
Message-Id: <200507041632.j64GWg5g090952@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	csjp@freebsd.org using -f
From: "Christian S.J. Peron" <csjp@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 79565 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jul 2005 16:32:43 -0000

http://perforce.freebsd.org/chv.cgi?CH=79565

Change 79565 by csjp@csjp_xor on 2005/07/04 16:32:16

	-Implement strsep loop optimization to prevent a second
	 walk of the dependency list.
	-Remove un-used variables

Affected files ...

.. //depot/projects/trustedbsd/mac/usr.sbin/getfhash/getfhash.c#11 edit

Differences ...

==== //depot/projects/trustedbsd/mac/usr.sbin/getfhash/getfhash.c#11 (text+ko) ====

@@ -142,8 +142,8 @@
 static void
 process_depends(const char *pathname)
 {
-	char **av, *depends[10], *dependlist;
-	int ndeps, error, i, j;
+	char *av, *dependlist;
+	int error, j;
 	ssize_t nbytes;
 
 	nbytes = extattr_get_file(pathname, MAC_CHKEXEC_ATTRN,
@@ -162,17 +162,14 @@
 	error = extattr_get_file(pathname, MAC_CHKEXEC_ATTRN,
 	    MAC_CHKEXEC_DEP, dependlist, nbytes);
 	dependlist[nbytes] = '\0';
-	for (ndeps = 0, av = depends;
-	    (*av = strsep(&dependlist, ":")) != NULL; ndeps++)
-		if (**av != '\0')
-			if (++av > &depends[10])
-				break;
 	depth++;
-	for (i = 0; i < ndeps; i++) {
+	for (; (av = strsep(&dependlist, ":")) != NULL;) {
+		if (strlen(av) == 0)
+			continue;
 		for (j = 0; j < depth; j++)
 			fputs("    ", stdout);
-		print_hash(depends[i]);
-	}
+		print_hash(av);
+        }
 	depth--;
 }