Date: Mon, 29 Oct 2018 23:35:51 +0300 From: Yuri Pankov <yuripv@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339826 - in head: sys/amd64/vmm/intel usr.sbin/bhyve Message-ID: <11b17c28-25fb-e578-5cc0-2e6f5fef2140@FreeBSD.org> In-Reply-To: <e877de10-6522-5e97-2cff-cb820d14772f@FreeBSD.org> References: <201810272124.w9RLOTpU054208@repo.freebsd.org> <e877de10-6522-5e97-2cff-cb820d14772f@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Mreip84OUE9htVsBeZSfkFXpsmy2bgXXX Content-Type: multipart/mixed; boundary="wjh5qvIVRbmYLEv8R15fKubObaqvf0GpF"; protected-headers="v1" From: Yuri Pankov <yuripv@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <11b17c28-25fb-e578-5cc0-2e6f5fef2140@FreeBSD.org> Subject: Re: svn commit: r339826 - in head: sys/amd64/vmm/intel usr.sbin/bhyve References: <201810272124.w9RLOTpU054208@repo.freebsd.org> <e877de10-6522-5e97-2cff-cb820d14772f@FreeBSD.org> In-Reply-To: <e877de10-6522-5e97-2cff-cb820d14772f@FreeBSD.org> --wjh5qvIVRbmYLEv8R15fKubObaqvf0GpF Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable John Baldwin wrote: > On 10/27/18 2:24 PM, Yuri Pankov wrote: >> Author: yuripv >> Date: Sat Oct 27 21:24:28 2018 >> New Revision: 339826 >> URL: https://svnweb.freebsd.org/changeset/base/339826 >> >> Log: >> Provide basic descriptions for VMX exit reason (from "Intel 64 and I= A-32 >> Architectures Software Developer=E2=80=99s Manual Volume 3"). Add t= he document >> to SEE ALSO in bhyve.8 (and pet manlint here a bit). >> =20 >> Reviewed by: jhb, rgrimes, 0mp >> Approved by: kib (mentor) >> Differential Revision: https://reviews.freebsd.org/D17531 >=20 > I did ask you to commit the bhyve.8 style fixes separately from the con= tent > changes in the review. While it is true we don't currently have active= > translations of manpages, it is still a good practice to follow to not = mix > style changes with content changes even in code commits as it obfuscate= s > the content changes. Understood, will do. I just (incorrectly) assumed your review approval to be "go ahead with this one, but next time don't mix content changes and cleanups", sorry about that. --wjh5qvIVRbmYLEv8R15fKubObaqvf0GpF-- --Mreip84OUE9htVsBeZSfkFXpsmy2bgXXX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Gq3PsPeLT4tL/9wk4vgf7Eq4WwFAlvXby4ACgkQk4vgf7Eq 4WyYjAgAq1F9KjxfkTDabiqVcgplW+an0Is3B3F0ARqJBmzXiMvKwrJjw7KBdL8k JKJbK7qXjb2KmX+DlwNKb8aUea6X0TKG+AqSt6PFmzECTgTt6sbfdQLyRzPXDomT v4av0WT53ZpmXcVK4P08GnHb3Thv09e6gGCDXDHS4xD0r/ZSK1L2v8B5NtJhS0Ro aXTpI+jjqDeeH3M3+tO+QVM5hMTs5sRkq+uMBaSx6MpFKVhSSopubZ9LMdixXzog MenUVecoecqgYhywca0TcIFVQktAJfMTeVoXm69BPTolFahqnrP7lee32DDsIGMa FvMeibQpLz7x4F1NXZSTtR/lkKHi9A== =JsOw -----END PGP SIGNATURE----- --Mreip84OUE9htVsBeZSfkFXpsmy2bgXXX--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?11b17c28-25fb-e578-5cc0-2e6f5fef2140>