From nobody Sat Aug 8 00:44:09 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hH2MZ3SRkz6mZTV for ; Sat, 08 Aug 2026 00:44:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hH2MZ1rBWz3whH for ; Sat, 08 Aug 2026 00:44:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786149850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=O2IteH8Fi+EoHzH8ezYDR+QGGsJI3eaXJ/12W1IzDhM=; b=vkiKF9CR/kJXod6l8FGNBORJnxz6/DMXy+Dcf0cMvU9wiJBo8jhMntx5UYxhjbsaNijt14 fezocb5YfdXn1mpFkycL1fy9+ypx8ZjWUYX22DP2FWaInKASWYLnZ7Kmk7CoY3wDhDkv5q GEdTwsOEJFYVrYDrjRLYlY3LwGvZh0ogGoIVbbUT7UpH/MXNGMSATiQW5zwVSiOiSQx4Gp wYllXPSA+7b4hJdRcEVTeQQZKQqfEYfEyJUhbsX8Orsa/uuHPEUcpVwCjCDWG/BZS7SsL/ jd26+VRR+AxtOzaIRxNn0FV7gX7KUWdbQRu+PCwvql/ifdHfhvgvNxEX5vdgCQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786149850; a=rsa-sha256; cv=none; b=ngn+1Xdmzw1Tzj2eypOi/Xit+Or2Sm7Z/kbdorXYAt96BD8QwgRJLBDa3vIVKQQXAEqJhu Plt+wrNp5XDeTPJEcvUlQuTDQhtqh5OirEIXVGZyDTVAMEHlpjh4k99SVMoLCMIALu/yZE xC7d17LfkwBKed/hGaOg4Sha0SdBEKWXvsM75GnxBybG9xGJ3kU81huYhvezMv281plLoK srxVxdkTNJ6MCrORW/oplO+JFCwiWOE3gHsr3KKSczlGTx/2kV3v/du/JWyB3XUCH8aSm5 MPmCHvlLort+mjBrQHOx7wgJYm1q2phWq3Ci3fR+Ac6RWDynjtsBVJpiGcV3aw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786149850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=O2IteH8Fi+EoHzH8ezYDR+QGGsJI3eaXJ/12W1IzDhM=; b=paLBFn+9cFS6v+oVKJ1/8y6eFU/cciKoTNXoHpGJ5hs/glG4zUI2HyHfz6+C7xbxwBS2j6 jJypjuuqJeLPbsaep3Ls9kyUk5YVYhcIZclNuZe2SSOjR03lWlK1PyCmj7xWJad8cei6R5 2agKmb3DMlKwtV9H8LebxvA7bXslWT1Zaze8s5U0YGj4qHrFibzfkdgAdv2OVYsO16uIwv HziP3eb0F3FtG3o+VkrXWCQtNCzbf1lub6HAIZI48t8hFH8FyqbeCfE4F2Mzwk2dbVntcU wunA+KSoDrLMskOb4bHs8umc3ylU6XWPcmscCSkyeK3/fmFFJ9IF+u1KyVfYDQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hH2MY6vZ4zlQ for ; Sat, 08 Aug 2026 00:44:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3ecbe by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 08 Aug 2026 00:44:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 49fc8bbbffae - stable/14 - ixgbe: avoid signed overflow in pause time calculation List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 49fc8bbbffae366e3063647b62e4f548226ddd94 Auto-Submitted: auto-generated Date: Sat, 08 Aug 2026 00:44:09 +0000 Message-Id: <6a767bd9.3ecbe.48d029bc@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=49fc8bbbffae366e3063647b62e4f548226ddd94 commit 49fc8bbbffae366e3063647b62e4f548226ddd94 Author: Kevin Bowling AuthorDate: 2026-07-28 11:10:09 +0000 Commit: Kevin Bowling CommitDate: 2026-08-08 00:42:06 +0000 ixgbe: avoid signed overflow in pause time calculation pause_time is promoted to signed int before multiplication. Its default value of 65535 multiplied by 65537 exceeds INT_MAX and triggers UBSAN, even though the result is assigned to a u32. Make the multiplier unsigned so the calculation has the intended u32 semantics. Linux commit 3b70683fc4d6 reported the failure in the generic path and used the same mechanical correction. The 82598-specific flow control operation contains the identical expression, so correct it as well. (cherry picked from commit 35374c3ec69aa87561431e6236706c485bdeeacc) --- sys/dev/ixgbe/ixgbe_82598.c | 2 +- sys/dev/ixgbe/ixgbe_common.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/ixgbe/ixgbe_82598.c b/sys/dev/ixgbe/ixgbe_82598.c index e32fdb8f039c..f27f263dd07f 100644 --- a/sys/dev/ixgbe/ixgbe_82598.c +++ b/sys/dev/ixgbe/ixgbe_82598.c @@ -535,7 +535,7 @@ s32 ixgbe_fc_enable_82598(struct ixgbe_hw *hw) } /* Configure pause time (2 TCs per register) */ - reg = hw->fc.pause_time * 0x00010001; + reg = hw->fc.pause_time * 0x00010001U; for (i = 0; i < (IXGBE_DCB_MAX_TRAFFIC_CLASS / 2); i++) IXGBE_WRITE_REG(hw, IXGBE_FCTTV(i), reg); diff --git a/sys/dev/ixgbe/ixgbe_common.c b/sys/dev/ixgbe/ixgbe_common.c index c836ccebff0c..6495bfdecc60 100644 --- a/sys/dev/ixgbe/ixgbe_common.c +++ b/sys/dev/ixgbe/ixgbe_common.c @@ -2932,7 +2932,7 @@ s32 ixgbe_fc_enable_generic(struct ixgbe_hw *hw) } /* Configure pause time (2 TCs per register) */ - reg = hw->fc.pause_time * 0x00010001; + reg = hw->fc.pause_time * 0x00010001U; for (i = 0; i < (IXGBE_DCB_MAX_TRAFFIC_CLASS / 2); i++) IXGBE_WRITE_REG(hw, IXGBE_FCTTV(i), reg);