From owner-svn-ports-all@FreeBSD.ORG Mon Apr 7 10:18:44 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 95511D2C for ; Mon, 7 Apr 2014 10:18:44 +0000 (UTC) Received: from mail-lb0-f169.google.com (mail-lb0-f169.google.com [209.85.217.169]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1DD397B1 for ; Mon, 7 Apr 2014 10:18:43 +0000 (UTC) Received: by mail-lb0-f169.google.com with SMTP id q8so4666777lbi.28 for ; Mon, 07 Apr 2014 03:18:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=JAsBTxV8yVA0XYSHjTrqS3VpvlIfhLl8uEZMGlvKDYA=; b=R8S6F2f/MoXAkTF/r87PAYTMhvGwtIY+z8XyCtr5IUrY4yNiqWEO8tQUo2aWRgApfF RAYOSuL0c/+ZmrBqWdIjt9JXjMaOIYAW43wa2l2mGnSOf3VZHOP27i8js0x27FKZ6Tjo c9/FFArK4OOMlC5ULD5Rx8aGB92TSZzobmjwkIlVD2EQtM2C65c6melptC5fsHlahe52 w9q8Jk8jWujUsB+65r0lPj7fNHvVAULltCE0mNA0htFFOxIoCY5GW85B8SI6ObmE00hI 76WaDnGvieaDxJmHYIb0xi6vcKNsCF6rgYWw8CcvQCaPItzujH/j9X+UgvEMXVHJPhTL sTZg== X-Gm-Message-State: ALoCoQly4ctRw/6wD4mx719PkEwg845wQv62Uj/F4eOXmns+RfRAdhR/lkqn5tgQqPHSUb0KHmTW X-Received: by 10.112.150.162 with SMTP id uj2mr629241lbb.52.1396865915860; Mon, 07 Apr 2014 03:18:35 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.112.26.177 with HTTP; Mon, 7 Apr 2014 03:18:15 -0700 (PDT) In-Reply-To: References: <201404060549.s365nYuf010306@svn.freebsd.org> From: Sunpoet Po-Chuan Hsieh Date: Mon, 7 Apr 2014 18:18:15 +0800 X-Google-Sender-Auth: vUwMbO0wyRTqomO65iwT9G4qENs Message-ID: Subject: Re: svn commit: r350329 - in head/devel/bisoncpp: . files To: Gerald Pfeifer Content-Type: text/plain; charset=UTF-8 Cc: Muhammad Moinur Rahman <5u623l20@gmail.com>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Apr 2014 10:18:44 -0000 On Mon, Apr 7, 2014 at 7:49 AM, Gerald Pfeifer wrote: > On Sun, 6 Apr 2014, Sunpoet Po-Chuan Hsieh wrote: >> Log: >> - Update to 4.08.00 >> - Pass maintainership to submitter >> - While I'm here, relax USE_GCC to yes >> >> Changes: http://sourceforge.net/projects/bisoncpp/files/bisonc%2B%2B/4.08.00/README/view >> http://sourceforge.net/projects/bisoncpp/files/bisonc%2B%2B/4.07.00/README/view >> http://sourceforge.net/projects/bisoncpp/files/bisonc%2B%2B/4.06.00/README/view >> PR: 188267 >> Submitted by: Muhammad Moinur Rahman <5u623l20@gmail.com> > >> Modified: head/devel/bisoncpp/Makefile >> ============================================================================== >> -USE_GCC= 4.7 >> +USE_GCC= yes > > This change is not correct. > > Check out the following lines later in this Makefile: > > @${REINPLACE_CMD} 's|"g++|"g++47|' \ > ${WRKSRC}/INSTALL.im \ > ${WRKSRC}/scanner/driver/build \ > ${WRKSRC}/parser/driver/build > @${REINPLACE_CMD} 's|"gcc|"gcc47|' \ > ${WRKSRC}/icmake/special > > This works by chance today since USE_GCC=yes defaults to GCC 4.7. > > It will break for anyone installing (only) lang/gcc48 or when we > switch to GCC 4.8 as default. > > Can you please fix this? > > Gerald > > PS: If ${CC} is set at this point, that would be the best option > instead of hard-coding things. Thank you, Gerald. I should use CC and CXX here. Is it OK? Index: Makefile =================================================================== --- Makefile (revision 350329) +++ Makefile (working copy) @@ -47,11 +47,11 @@ @${REINPLACE_CMD} 's|%%PREFIX%%|${PREFIX}|g; \ s|%%PORTVERSION%%|${PORTVERSION}|g' \ ${WRKSRC}/INSTALL.im - @${REINPLACE_CMD} 's|"g++|"g++47|' \ + @${REINPLACE_CMD} 's|"g++|"${CXX}|' \ ${WRKSRC}/INSTALL.im \ ${WRKSRC}/scanner/driver/build \ ${WRKSRC}/parser/driver/build - @${REINPLACE_CMD} 's|"gcc|"gcc47|' \ + @${REINPLACE_CMD} 's|"gcc|"${CC}|' \ ${WRKSRC}/icmake/special @${REINPLACE_CMD} 's|"cp -d |"cp -Pp | ; \ s|"cp -r |"cp -R | ; \ Regards, sunpoet