From owner-freebsd-arch@FreeBSD.ORG  Tue Jun  9 23:42:32 2009
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F33EB106568B
	for <arch@freebsd.org>; Tue,  9 Jun 2009 23:42:31 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id B28D78FC16
	for <arch@freebsd.org>; Tue,  9 Jun 2009 23:42:31 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id n59NgUa1052658
	for <arch@freebsd.org>; Tue, 9 Jun 2009 17:42:30 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Tue, 09 Jun 2009 17:42:49 -0600 (MDT)
Message-Id: <20090609.174249.-1435625969.imp@bsdimp.com>
To: arch@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: 
Subject: devclass_find_free_unit
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jun 2009 23:42:32 -0000

What purpose does devclass_find_free_unit serve?  I think it can safely be
eliminated from the tree.  The current design is racy.

Comments?

It is currently used:

./arm/xscale/ixp425/.svn/text-base/avila_ata.c.svn-base:        device_add_child(dev, "ata", devclass_find_free_unit(ata_devclass, 0));
./arm/xscale/ixp425/avila_ata.c:        device_add_child(dev, "ata", devclass_find_free_unit(ata_devclass, 0));
./arm/at91/.svn/text-base/at91_cfata.c.svn-base:        device_add_child(dev, "ata", devclass_find_free_unit(ata_devclass, 0));
./arm/at91/at91_cfata.c:        device_add_child(dev, "ata", devclass_find_free_unit(ata_devclass, 0));
./powerpc/psim/.svn/text-base/ata_iobus.c.svn-base:                      devclass_find_free_unit(ata_devclass, 0));

# All the above can be replaced with a simple '-1'.

ata/ata-pci.c:      unit : devclass_find_free_unit(ata_devclass, 2));
ata/ata-usb.c:              devclass_find_free_unit(ata_devclass, 2))) == NULL) {

These can likely be replaced by '2', but that may result in a warning
message being printed that likely can be eliminated...

comments?

Warner