Date: Fri, 6 Apr 2001 03:54:59 +0400 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: Matt Dillon <dillon@earth.backplane.com> Cc: Mark.Andrews@nominum.com, Chris Byrnes <chris@jeah.net>, security@FreeBSD.ORG Subject: Re: ntpd patch Message-ID: <20010406035459.A6350@nagual.pp.ru> In-Reply-To: <200104052328.f35NSN232886@earth.backplane.com>; from dillon@earth.backplane.com on Thu, Apr 05, 2001 at 04:28:23PM -0700 References: <200104052314.f35NE6T54121@drugs.dv.isc.org> <200104052328.f35NSN232886@earth.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 05, 2001 at 16:28:23 -0700, Matt Dillon wrote: > Off-by-1 fix + > buffer underflow http://apollo.backplane.com/FreeBSD/ntpd-patch2.diff > For this one please change + while (tp != buf && isspace((int)(*(tp-1)))) to + while (tp != buf && isspace((unsigned char)(*(tp-1)))) (int) cast is completely wrong and dangerous. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-security" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010406035459.A6350>