From owner-cvs-src@FreeBSD.ORG Tue May 6 18:14:50 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 290851065677 for ; Tue, 6 May 2008 18:14:50 +0000 (UTC) (envelope-from joerg@britannica.bec.de) Received: from www.pkgsrc-box.org (www.ostsee-abc.de [62.206.222.50]) by mx1.freebsd.org (Postfix) with ESMTP id 3298C8FC19 for ; Tue, 6 May 2008 18:14:49 +0000 (UTC) (envelope-from joerg@britannica.bec.de) Received: from britannica.bec.de (www.pkgsrc-box.org [127.0.0.1]) by www.pkgsrc-box.org (Postfix) with ESMTP id 7A496E506AA for ; Tue, 6 May 2008 17:49:15 +0000 (UTC) Received: by britannica.bec.de (Postfix, from userid 1000) id CCD2916FC2; Tue, 6 May 2008 19:49:27 +0200 (CEST) Date: Tue, 6 May 2008 19:49:27 +0200 From: Joerg Sonnenberger To: cvs-src@freebsd.org Message-ID: <20080506174927.GE5989@britannica.bec.de> References: <200805021525.m42FP7GC055065@repoman.freebsd.org> <200805051127.45177.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200805051127.45177.jhb@freebsd.org> User-Agent: Mutt/1.5.17 (2007-11-01) Subject: Re: cvs commit: src/include stdio.h src/lib/libc/stdio Makefile.inc clrerr.c feof.c ferror.c fileno.c getc.c getchar.c local.h putc.c putchar.c unlocked.c xprintf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 May 2008 18:14:50 -0000 On Mon, May 05, 2008 at 11:27:44AM -0400, John Baldwin wrote: > I'll be reverting this shortly. I had misparsed the maze of stdio headers in > glibc and thought that it had a fully opaque FILE. I will probably not > restore unlocked.c though and just leave foo_unlocked() in foo.c. I will > restore all the inlining though since there's not much point in axeing that > if we can't make FILE private. I've seen a bunch of interesting problems when making FILE opaque in DragonFly. A bunch of programs want to mess with it, e.g. mh is pretty bad. Even worse is modern gnulib, which also depends on using stdio internals. I've seen one case where FILE was copied in screen... Joerg