From owner-svn-ports-all@freebsd.org Fri Apr 7 21:32:24 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D0F9BD33CAC; Fri, 7 Apr 2017 21:32:24 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AB396D90; Fri, 7 Apr 2017 21:32:24 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id C6F505D03; Fri, 7 Apr 2017 21:32:23 +0000 (UTC) From: Jan Beich To: Matthew Rezny Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r437953 - in head/lang/beignet: . files References: <201704071930.v37JUBGj017948@repo.freebsd.org> <24496938.jsC6qZ9reS@workstation.reztek> Date: Fri, 07 Apr 2017 23:34:03 +0200 In-Reply-To: <24496938.jsC6qZ9reS@workstation.reztek> (Matthew Rezny's message of "Fri, 07 Apr 2017 22:53:27 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 21:32:24 -0000 Matthew Rezny writes: > On Friday 07 April 2017 22:23:18 Jan Beich wrote: > >> Matthew Rezny writes: >> > - Enable OpenCL 2.0 on AMD64 >> >> Isn't this premature before 1.3.2 or bug 217635 fix? >> > There was no clear answer given in that PR as to whether or not version 1.3.1 > addressed the issue, but as I understood it the issue in that PR was caused by > a lack of OpenCL 2.0 so I do not see how enabling it would be premature. DRM_IOCTL_I915_GEM_USERPTR is only available on drm-next but even there is half broken. Beignet *requires* it for OpenCL 2.0 but, looking more, the default is still 1.2. The patch just limits the ioctl to when an application explicitly requests 2.0. If you want a clear answer look no further than comment 0. OpenCL 2.0 support upstream *is* the source of the regression. The patch just have a different effect on 1.3.0 and 1.3.1 but still required for both on FreeBSD. > >> > +USE_LDCONFIG= ${LOCALBASE}/lib/${PORTNAME} >> >> Why do you need ldconfig hints for dlopen(3)? libcl.so embeds absolute >> paths for libgbe.so and libgbeinterp.so + absolutepath via ocl-icd >> config in /usr/local/etc/OpenCL/vendors/intel-beignet.icd >> >> Please, don't turn portlint into a cargo cult. >> > Nothing to do with portlint, just following what is written in the Porter's > Handbook about ports that install shared libraries and USE_LDCONFIG. Porter's Handook says "Please double-check, often this is not necessary at all". For an X11-related example, dri, libva, libvdpau, xorg-server load modules under /usr/local/lib/foo without adding it to USE_LDCONFIG e.g., /usr/local/lib/xorg/modules/libglamoregl.so >> > +LLVMVER= ${MESA_LLVM_VER:U39} >> >> Why not drop LLVMVER variable and use MESA_LLVM_VER directly? >> >> BUILD_DEPENDS= clang${MESA_LLVM_VER}:devel/llvm${MESA_LLVM_VER} \ >> [...] >> MESA_LLVM_VER?= 39 > > Conversely, why do it that way? I see no benefit, just more lines changed. ${LLVMVER} != ${MESA_LLVM_VER} cannot happen, so an extra variable may confuse the next maintainer.