From owner-freebsd-arch@FreeBSD.ORG Mon Jan 4 23:06:59 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C04AC106566C; Mon, 4 Jan 2010 23:06:59 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (unknown [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 089E08FC15; Mon, 4 Jan 2010 23:06:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o04MrhgA064016; Mon, 4 Jan 2010 15:53:43 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 04 Jan 2010 15:54:25 -0700 (MST) Message-Id: <20100104.155425.497362415505643888.imp@bsdimp.com> To: dougb@freebsd.org From: "M. Warner Losh" In-Reply-To: <4B4268EB.3040905@FreeBSD.org> References: <201001042130.o04LU4ln085140@svn.freebsd.org> <20100104.144005.262629641795617719.imp@bsdimp.com> <4B4268EB.3040905@FreeBSD.org> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: arch@freebsd.org Subject: Re: svn commit: r201534 - in head/sys: amd64/conf arm/conf i386/conf ia64/conf mips/conf pc98/conf powerpc/conf sparc64/conf sun4v/conf X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2010 23:06:59 -0000 In message: <4B4268EB.3040905@FreeBSD.org> Doug Barton writes: : I originally proposed adding it to GENERIC because my sentiment was : the same as yours on this. After posting the patch for review I was : told by several people (whom I felt were better acquainted with sys/ : than I) to add it to DEFAULTS instead, so I changed the patch and : committed it, then MFC'ed it after an appropriate window. : : As far as whether to add it to "the default kernel configuration" : (leaving aside what file it should go into for now) the discussion : about that happened on -current in the vicinity of 12/13 where it : received what I felt was pretty good support. Given that disk space is : practically free on modern systems, and given the overwhelming utility : of having at least the basic (without comments) config file included : in the kernel for people who need to do real sysadmin work, I regard : the question of whether or not it should go in as settled. (In fact, : as I said in the thread I thought it had been done a long time ago.) I : am however willing to wait a couple days for those on this list to : offer an incredibly compelling reason why this would be a bad thing. Yes. I missed the original discussion in -current until today. I'm sorry about that. -current is a high volume list and I sometimes overlook things... : My preference would actually be that it be added to GENERIC. I'll take : you up on your offer and let you add it there if you have the time to : do so. If you don't and I get to it first, no worries. Either way, I : do want it done in time to be included in 7.3-RELEASE. I'll move the stuff to GENERIC (and other config files as appropriate for ppc, mips and arm). I have been doing prototyping in this area to try to make things better, but nothing quite ready to share. : In regards to your backing out the change without discussing it with : me first, in this particular case there is no harm done, and : ultimately I agree with your assessment that it's overwhelmingly : likely that the end result will be that the change in DEFAULTS will : not stay. However, this situation is far from an emergency (given that : it had been the way it was for so long). Should a similar situation : arise in the future as a general course of action I would prefer that : the standard procedures be followed. Yes. I think you are right here. I think that I jumped the gun a little. Too eager to start working in the new year. I'll be better about following procedure in the future. Sorry for any heartache this caused you. Warner : Doug : : : M. Warner Losh wrote: : > Doug (with arch@ cc'd) : > : > I'm sorry that I didn't notice this sooner and comment upon it. It is : > a really bad idea for a lot of reasons.. : > : > The DEFAULTS file is not for optional items. It is only for items : > that are required for all (or almost all) users of the system to build : > a working kernel. Including the config file isn't anywhere near : > required. In addition, changing it on a stable branch seems like a : > big default change. Finally, we're planning on deprecating this file : > entirely in the future, so no further changes should be made to it : > without discussion. : > : > I've reverted this after chatting on IRC with bz@ and ed@. : > : > I'm posting this to arch@ so that the followup discussion can take : > place. *IF* there is wide-spread consensus to add it back, I'll take : > care of that leg work (as well as anything I've overlooked in the : > back out). But I don't think there's wide-spread support for this in : > DEFAULTS... : > : > Warner : > : > In message: <201001042130.o04LU4ln085140@svn.freebsd.org> : > Warner Losh writes: : > : Author: imp : > : Date: Mon Jan 4 21:30:04 2010 : > : New Revision: 201534 : > : URL: http://svn.freebsd.org/changeset/base/201534 : > : : > : Log: : > : Revert 200594. This file isn't intended for these sorts of things. : > : : > : Modified: : > : head/sys/amd64/conf/DEFAULTS : > : head/sys/arm/conf/DEFAULTS : > : head/sys/i386/conf/DEFAULTS : > : head/sys/ia64/conf/DEFAULTS : > : head/sys/mips/conf/DEFAULTS : > : head/sys/pc98/conf/DEFAULTS : > : head/sys/powerpc/conf/DEFAULTS : > : head/sys/sparc64/conf/DEFAULTS : > : head/sys/sun4v/conf/DEFAULTS : > : : > : Modified: head/sys/amd64/conf/DEFAULTS : > : ============================================================================== : > : --- head/sys/amd64/conf/DEFAULTS Mon Jan 4 21:02:01 2010 (r201533) : > : +++ head/sys/amd64/conf/DEFAULTS Mon Jan 4 21:30:04 2010 (r201534) : > : @@ -20,10 +20,3 @@ options GEOM_PART_BSD : > : options GEOM_PART_EBR : > : options GEOM_PART_EBR_COMPAT : > : options GEOM_PART_MBR : > : - : > : -# Store the plain version of the configuration file in the kernel itself. : > : -# To store the entire file, including comments, put this in /etc/src.conf: : > : -# CONFIGARGS= -C : > : -# See config(8) for more details. : > : -# : > : -options INCLUDE_CONFIG_FILE # Include this file in kernel : > : : > : Modified: head/sys/arm/conf/DEFAULTS : > : ============================================================================== : > : --- head/sys/arm/conf/DEFAULTS Mon Jan 4 21:02:01 2010 (r201533) : > : +++ head/sys/arm/conf/DEFAULTS Mon Jan 4 21:30:04 2010 (r201534) : > : @@ -9,10 +9,3 @@ device mem : > : : > : options GEOM_PART_BSD : > : options GEOM_PART_MBR : > : - : > : -# Store the plain version of the configuration file in the kernel itself. : > : -# To store the entire file, including comments, put this in /etc/src.conf: : > : -# CONFIGARGS= -C : > : -# See config(8) for more details. : > : -# : > : -options INCLUDE_CONFIG_FILE # Include this file in kernel : > : : > : Modified: head/sys/i386/conf/DEFAULTS : > : ============================================================================== : > : --- head/sys/i386/conf/DEFAULTS Mon Jan 4 21:02:01 2010 (r201533) : > : +++ head/sys/i386/conf/DEFAULTS Mon Jan 4 21:30:04 2010 (r201534) : > : @@ -28,10 +28,3 @@ options GEOM_PART_MBR : > : # enable support for native hardware : > : options NATIVE : > : device atpic : > : - : > : -# Store the plain version of the configuration file in the kernel itself. : > : -# To store the entire file, including comments, put this in /etc/src.conf: : > : -# CONFIGARGS= -C : > : -# See config(8) for more details. : > : -# : > : -options INCLUDE_CONFIG_FILE # Include this file in kernel : > : : > : Modified: head/sys/ia64/conf/DEFAULTS : > : ============================================================================== : > : --- head/sys/ia64/conf/DEFAULTS Mon Jan 4 21:02:01 2010 (r201533) : > : +++ head/sys/ia64/conf/DEFAULTS Mon Jan 4 21:30:04 2010 (r201534) : > : @@ -17,10 +17,3 @@ device uart_ns8250 : > : options GEOM_PART_BSD : > : options GEOM_PART_GPT : > : options GEOM_PART_MBR : > : - : > : -# Store the plain version of the configuration file in the kernel itself. : > : -# To store the entire file, including comments, put this in /etc/src.conf: : > : -# CONFIGARGS= -C : > : -# See config(8) for more details. : > : -# : > : -options INCLUDE_CONFIG_FILE # Include this file in kernel : > : : > : Modified: head/sys/mips/conf/DEFAULTS : > : ============================================================================== : > : --- head/sys/mips/conf/DEFAULTS Mon Jan 4 21:02:01 2010 (r201533) : > : +++ head/sys/mips/conf/DEFAULTS Mon Jan 4 21:30:04 2010 (r201534) : > : @@ -11,10 +11,3 @@ device uart_ns8250 : > : : > : options GEOM_PART_BSD : > : options GEOM_PART_MBR : > : - : > : -# Store the plain version of the configuration file in the kernel itself. : > : -# To store the entire file, including comments, put this in /etc/src.conf: : > : -# CONFIGARGS= -C : > : -# See config(8) for more details. : > : -# : > : -options INCLUDE_CONFIG_FILE # Include this file in kernel : > : : > : Modified: head/sys/pc98/conf/DEFAULTS : > : ============================================================================== : > : --- head/sys/pc98/conf/DEFAULTS Mon Jan 4 21:02:01 2010 (r201533) : > : +++ head/sys/pc98/conf/DEFAULTS Mon Jan 4 21:30:04 2010 (r201534) : > : @@ -24,10 +24,3 @@ device uart_ns8250 : > : # Default partitioning schemes : > : options GEOM_PART_BSD : > : options GEOM_PART_PC98 : > : - : > : -# Store the plain version of the configuration file in the kernel itself. : > : -# To store the entire file, including comments, put this in /etc/src.conf: : > : -# CONFIGARGS= -C : > : -# See config(8) for more details. : > : -# : > : -options INCLUDE_CONFIG_FILE # Include this file in kernel : > : : > : Modified: head/sys/powerpc/conf/DEFAULTS : > : ============================================================================== : > : --- head/sys/powerpc/conf/DEFAULTS Mon Jan 4 21:02:01 2010 (r201533) : > : +++ head/sys/powerpc/conf/DEFAULTS Mon Jan 4 21:30:04 2010 (r201534) : > : @@ -14,10 +14,3 @@ device uart_z8530 : > : : > : options GEOM_PART_APM : > : options GEOM_PART_MBR : > : - : > : -# Store the plain version of the configuration file in the kernel itself. : > : -# To store the entire file, including comments, put this in /etc/src.conf: : > : -# CONFIGARGS= -C : > : -# See config(8) for more details. : > : -# : > : -options INCLUDE_CONFIG_FILE # Include this file in kernel : > : : > : Modified: head/sys/sparc64/conf/DEFAULTS : > : ============================================================================== : > : --- head/sys/sparc64/conf/DEFAULTS Mon Jan 4 21:02:01 2010 (r201533) : > : +++ head/sys/sparc64/conf/DEFAULTS Mon Jan 4 21:30:04 2010 (r201534) : > : @@ -19,10 +19,3 @@ options GEOM_PART_VTOC8 : > : : > : # Let sunkbd emulate an AT keyboard by default. : > : options SUNKBD_EMULATE_ATKBD : > : - : > : -# Store the plain version of the configuration file in the kernel itself. : > : -# To store the entire file, including comments, put this in /etc/src.conf: : > : -# CONFIGARGS= -C : > : -# See config(8) for more details. : > : -# : > : -options INCLUDE_CONFIG_FILE # Include this file in kernel : > : : > : Modified: head/sys/sun4v/conf/DEFAULTS : > : ============================================================================== : > : --- head/sys/sun4v/conf/DEFAULTS Mon Jan 4 21:02:01 2010 (r201533) : > : +++ head/sys/sun4v/conf/DEFAULTS Mon Jan 4 21:30:04 2010 (r201534) : > : @@ -11,10 +11,3 @@ device mem # Memory and kernel memory : > : # Default partitioning schemes : > : options GEOM_PART_BSD : > : options GEOM_PART_VTOC8 : > : - : > : -# Store the plain version of the configuration file in the kernel itself. : > : -# To store the entire file, including comments, put this in /etc/src.conf: : > : -# CONFIGARGS= -C : > : -# See config(8) for more details. : > : -# : > : -options INCLUDE_CONFIG_FILE # Include this file in kernel : > : : > : : : -- : : Improve the effectiveness of your Internet presence with : a domain name makeover! http://SupersetSolutions.com/ : : Computers are useless. They can only give you answers. : -- Pablo Picasso : :