From owner-freebsd-bugs@freebsd.org Tue Jan 5 23:53:26 2016 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9E450A638B7 for ; Tue, 5 Jan 2016 23:53:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7455A1D27 for ; Tue, 5 Jan 2016 23:53:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u05NrQA3027026 for ; Tue, 5 Jan 2016 23:53:26 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 205938] [ext2fs][patch][panic] EXT4: reading mmaped file causes panic because struct buf leaks Date: Tue, 05 Jan 2016 23:53:26 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: crash, patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: damjan.jov@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter cc attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2016 23:53:26 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D205938 Bug ID: 205938 Summary: [ext2fs][patch][panic] EXT4: reading mmaped file causes panic because struct buf leaks Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Keywords: crash, patch Severity: Affects Many People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: damjan.jov@gmail.com CC: freebsd-fs@FreeBSD.org Created attachment 165127 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D165127&action= =3Dedit Fix a kernel panic when reading mmaped files from EXT4 Calling mmap() on any sizeable file on an EXT4 filesystem, and then attempt= ing to read that memory (can be easily tested using the "cmp file file" tool), causes a reproducible kernel panic: userret: returning with the following locks held: exclusive lockmgr bufwait (bufwait) r =3D 0 (0xfffffe001d90c220) locked @ /usr/src/sys/kern/vfs_bio.c:1454 panic: witness_warn cpuid =3D 0 KDB: stack backtrace: db_trace_self_wrapper() at db_trace-self_wrapper+0x2b/frame 0xfffffe002b7e6= 7f0 vpanic() at vpanic+0x182/frame 0xfffffe002b7e6870 kassert_panic() at kassert_panic+0x126/frame 0xfffffe002b7e68e0 witness_warn() at witness_warn+0x3c6/frame 0xfffffe002b7e69b0 userret() at userret+0x98/frame 0xfffffe002b7e69e0 trap() at trap+0x3f4/frame 0xfffffe002b7e6bf0 calltrap() at calltrap+0x8/frame 0xfffffe002b7e6bf0 --- trap 0xc, rip =3D 0x4019c0, rsp =3D 0x7fffffffe940, rbp =3D 0x7ffffffff= eea30 --- KDB: enter: panic [ thread pid 909 tid 100082 ] Stopped at kdb_enter+0x3b: movq $0,kdb_why The problem comes from ext4_bmapext() in sys/fs/ext2fs/ext2_bmap.c never calling brelse(), meaning the "struct buf" returned in path.ep_bp from ext4_ext_find_extent() is never released/unlocked, something userret() catc= hes later and panics from. The attached patch always calls brelse(path.ep_bp), fixing reading EXT4 fil= es using mmap(). This affects all versions of FreeBSD. --=20 You are receiving this mail because: You are the assignee for the bug.=