Date: Thu, 19 Jan 2023 03:52:07 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: eee5ebb851be - stable/13 - bnxt: Remove dead write to cp_ring_id Message-ID: <202301190352.30J3q7fT021820@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=eee5ebb851beb1874b5e9d6f8b329b4ab67990c0 commit eee5ebb851beb1874b5e9d6f8b329b4ab67990c0 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2022-02-28 17:13:27 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2023-01-19 00:59:42 +0000 bnxt: Remove dead write to cp_ring_id Since this is read from memory, reading it and then ignoring it is dead code... Sponsored by: Netflix (cherry picked from commit 44b4f0370fe90d11306e9d3fdcacdc5b4ccc946e) --- sys/dev/bnxt/bnxt_hwrm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/bnxt/bnxt_hwrm.c b/sys/dev/bnxt/bnxt_hwrm.c index 60485cd06799..0009ffa25053 100644 --- a/sys/dev/bnxt/bnxt_hwrm.c +++ b/sys/dev/bnxt/bnxt_hwrm.c @@ -119,7 +119,6 @@ _hwrm_send_message(struct bnxt_softc *softc, void *msg, uint32_t msg_len) struct hwrm_err_output *resp = (void *)softc->hwrm_cmd_resp.idi_vaddr; uint32_t *data = msg; int i; - uint16_t cp_ring_id; uint8_t *valid; uint16_t err; uint16_t max_req_len = HWRM_MAX_REQ_LEN; @@ -128,7 +127,6 @@ _hwrm_send_message(struct bnxt_softc *softc, void *msg, uint32_t msg_len) /* TODO: DMASYNC in here. */ req->seq_id = htole16(softc->hwrm_cmd_seq++); memset(resp, 0, PAGE_SIZE); - cp_ring_id = le16toh(req->cmpl_ring); if (softc->flags & BNXT_FLAG_SHORT_CMD) { void *short_cmd_req = softc->hwrm_short_cmd_req_addr.idi_vaddr;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202301190352.30J3q7fT021820>