From owner-freebsd-java@FreeBSD.ORG Wed May 16 12:47:53 2012 Return-Path: Delivered-To: freebsd-java@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id ACCEA1065677 for ; Wed, 16 May 2012 12:47:53 +0000 (UTC) (envelope-from bryan@shatow.net) Received: from secure.xzibition.com (secure.xzibition.com [173.160.118.92]) by mx1.freebsd.org (Postfix) with ESMTP id 539AE8FC18 for ; Wed, 16 May 2012 12:47:53 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=shatow.net; h=message-id :date:from:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; q=dns; s=sweb; b=Smwctv muzLeylQO/mnFQNw3pki1ZS4zuKbWdOqDJ0pxAcrkDjAI72CIOa0pi+q7R1S1WKK Te4ukO3rultK5woWJRoUURiOYKop96HHoPZMXiqF2g0AIecXRbIIc3j5fbfG5ihd GMNroO8RCwAJfFZfb2/I8P06pf9YyPuKRmxfo= DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=shatow.net; h=message-id :date:from:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; s=sweb; bh=D3XE0KAQtak1 Yf1rEdpSAUW6bwVtlgMUS7louPcxGbA=; b=pv94Uv6TNzgRMqmrsFNWkQ4qzcS2 9zoJjYL99i+9Viyjh7lkInJWlDUspqHeD8iwQ5N//SgZE0Q/NMhEoE+Zq0j+pmzQ B8Sf5u3XfU5qF16GJ8fnaTZmiE4L0cKsxdf1VQ0n0jWVnBxLeP3kQvefvAnW5Lum vLBsMWJzkJQX2sQ= Received: (qmail 99747 invoked from network); 16 May 2012 07:47:51 -0500 Received: from unknown (HELO ?10.10.1.87?) (bryan@shatow.net@10.10.1.87) by sweb.xzibition.com with ESMTPA; 16 May 2012 07:47:51 -0500 Message-ID: <4FB3A1F5.30006@shatow.net> Date: Wed, 16 May 2012 07:47:49 -0500 From: Bryan Drewery User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Jung-uk Kim References: <201205150540.q4F5e5Jb001282@freefall.freebsd.org> <4FB29704.8080605@FreeBSD.org> In-Reply-To: <4FB29704.8080605@FreeBSD.org> X-Enigmail-Version: 1.4.1 OpenPGP: id=3C9B0CF9; url=http://www.shatow.net/bryan/bryan.asc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: glewis@FreeBSD.org, freebsd-java@freebsd.org Subject: Re: ports/167903: [PATCH] java/openjdk6: Fix build failure in 8.3 jail running on 9+ system X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 May 2012 12:47:53 -0000 On 5/15/2012 12:48 PM, Jung-uk Kim wrote: > I don't think this patch is acceptable because it introduces unnecessary > dependency for "normal" case. The upstream bins are built on FreeBSD 7 aren't they? It would seem that the misc/compat7x dependency is real and makes sense. Do you have another idea on how to fix? > > In fact, the patch in 138638 was incomplete and it had to add this: > > --- diablo-jdk16/Makefile.orig 2012-05-15 13:19:41.000000000 -0400 > +++ diablo-jdk16/Makefile 2012-05-15 13:42:23.000000000 -0400 > @@ -44,7 +44,7 @@ > SUB_LIST+= ARCH="${ARCH}" \ > JDK_VERSION="${JDK_VERSION}" > > -PKG_IGNORE_DEPENDS= '^[^x|^j]' > +PKG_IGNORE_DEPENDS= '^[^c|^j|^x]' > > INSTALL_DIR= ${PREFIX}/${PKGNAMEPREFIX}jdk${JDK_VERSION} > > After this change, we have: > > # pkg_info -r diablo-jdk-1.6.0.07.02_19 > Information for diablo-jdk-1.6.0.07.02_19: > > Depends on: > Dependency: xproto-7.0.22 > Dependency: xextproto-7.2.0 > Dependency: compat7x-amd64-7.3.703000.201008_1 > Dependency: javavmwrapper-2.3.5 > Dependency: java-zoneinfo-2012.c Good catch. Considering my PR/patch is only for java/openjdk16, I'll let you submit yours for java/diablo-jdk6. Regards, Bryan Drewery