Date: Wed, 16 May 2012 07:47:49 -0500 From: Bryan Drewery <bryan@shatow.net> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: glewis@FreeBSD.org, freebsd-java@freebsd.org Subject: Re: ports/167903: [PATCH] java/openjdk6: Fix build failure in 8.3 jail running on 9+ system Message-ID: <4FB3A1F5.30006@shatow.net> In-Reply-To: <4FB29704.8080605@FreeBSD.org> References: <201205150540.q4F5e5Jb001282@freefall.freebsd.org> <4FB29704.8080605@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5/15/2012 12:48 PM, Jung-uk Kim wrote:
> I don't think this patch is acceptable because it introduces unnecessary
> dependency for "normal" case.
The upstream bins are built on FreeBSD 7 aren't they? It would seem that
the misc/compat7x dependency is real and makes sense.
Do you have another idea on how to fix?
>
> In fact, the patch in 138638 was incomplete and it had to add this:
>
> --- diablo-jdk16/Makefile.orig 2012-05-15 13:19:41.000000000 -0400
> +++ diablo-jdk16/Makefile 2012-05-15 13:42:23.000000000 -0400
> @@ -44,7 +44,7 @@
> SUB_LIST+= ARCH="${ARCH}" \
> JDK_VERSION="${JDK_VERSION}"
>
> -PKG_IGNORE_DEPENDS= '^[^x|^j]'
> +PKG_IGNORE_DEPENDS= '^[^c|^j|^x]'
>
> INSTALL_DIR= ${PREFIX}/${PKGNAMEPREFIX}jdk${JDK_VERSION}
>
> After this change, we have:
>
> # pkg_info -r diablo-jdk-1.6.0.07.02_19
> Information for diablo-jdk-1.6.0.07.02_19:
>
> Depends on:
> Dependency: xproto-7.0.22
> Dependency: xextproto-7.2.0
> Dependency: compat7x-amd64-7.3.703000.201008_1
> Dependency: javavmwrapper-2.3.5
> Dependency: java-zoneinfo-2012.c
Good catch. Considering my PR/patch is only for java/openjdk16, I'll let
you submit yours for java/diablo-jdk6.
Regards,
Bryan Drewery
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FB3A1F5.30006>