From owner-svn-src-all@freebsd.org Mon Sep 23 18:29:06 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7C592FC106; Mon, 23 Sep 2019 18:29:06 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46cXsG2QjZz4Ltl; Mon, 23 Sep 2019 18:29:06 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f44.google.com with SMTP id b136so35916636iof.3; Mon, 23 Sep 2019 11:29:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=rTV0Q1BpiYiRTMiE7CKr3s4xIOiRzy1D/H4AJAWFgW0=; b=KaoFh+3d1MtQTPd5ahaCPkM+tiIAGzQQqpsAY/82zYS+ypc18yjviPOoHB2n96UWPu uSXAPjgrS/Prk24l0lzC4LX9PdVuiN7o6utbeZ726GPmffOpbg1j/7WUyO1QX/ekiMP8 bh1n1AgGY+zkgP1lTNi16OJt0zHfsc7BVvbyJ/2nX6KUCrcD6t7wHby8umq1mEQDKNX+ 3/S6GF+k71YPclBgaENbPeSESDQ6celZVxokimb60nnU1aH3IbJfYqLxoZEW3KpCq1FZ LdCG2E9+wvsR9BxdpP7hl5UwacztPslx2DRJxMJUB+4UbqLUoJGIGGMzR00ODJ1XElFs pZcw== X-Gm-Message-State: APjAAAUoMm7Ln+PLvsiKGXFuN5oxfdf6lwL7Cbj9nAnF1cjY4JipndIx Z/grkbaYs8sac+OvCzga86wn0ifw X-Google-Smtp-Source: APXvYqw5eYvMhTwRin62/LvW58pgahbd1hjnNFLZblzlitG/LH+apkr/yD2eBdbjRsSG+6f2GvkRdw== X-Received: by 2002:a6b:3804:: with SMTP id f4mr790121ioa.166.1569263344817; Mon, 23 Sep 2019 11:29:04 -0700 (PDT) Received: from mail-io1-f50.google.com (mail-io1-f50.google.com. [209.85.166.50]) by smtp.gmail.com with ESMTPSA id f8sm12449459ioo.27.2019.09.23.11.29.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2019 11:29:04 -0700 (PDT) Received: by mail-io1-f50.google.com with SMTP id n197so35866855iod.9; Mon, 23 Sep 2019 11:29:04 -0700 (PDT) X-Received: by 2002:a5e:990f:: with SMTP id t15mr741305ioj.270.1569263344078; Mon, 23 Sep 2019 11:29:04 -0700 (PDT) MIME-Version: 1.0 References: <201909231414.x8NEEh9e040728@repo.freebsd.org> In-Reply-To: <201909231414.x8NEEh9e040728@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Mon, 23 Sep 2019 11:28:52 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r352623 - in head/sys: amd64/amd64 kern To: Mark Johnston Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46cXsG2QjZz4Ltl X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Sep 2019 18:29:06 -0000 Hi Mark, On Mon, Sep 23, 2019 at 7:14 AM Mark Johnston wrote: > > Author: markj > Date: Mon Sep 23 14:14:43 2019 > New Revision: 352623 > URL: https://svnweb.freebsd.org/changeset/base/352623 > > Log: > Use elf_relocaddr() when handling R_X86_64_RELATIVE relocations. > > This is required for DPCPU and VNET data variable definitions to work when > KLDs are linked as DSOs. R_X86_64_RELATIVE relocations should not appear > in object files, so assert this in elf_relocaddr(). Is the goal to eventually link amd64 KLDs as DSOs? I might be confusing the terminology, but I believe amd64 .ko's today are unlinked ordinary object files, rather than shared objects. (I believe they use kern/link_elf_obj.c rather than kern/link_elf.c today.) If so: great! Thanks, Conrad