From owner-cvs-src@FreeBSD.ORG Tue Apr 15 07:36:40 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B806A37B401; Tue, 15 Apr 2003 07:36:40 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id C37EC43FAF; Tue, 15 Apr 2003 07:36:39 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.8/8.12.3) with ESMTP id h3FEacA7063024; Tue, 15 Apr 2003 08:36:38 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Tue, 15 Apr 2003 08:36:15 -0600 (MDT) Message-Id: <20030415.083615.91276433.imp@bsdimp.com> To: mdodd@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20030415102955.S99028@sasami.jurai.net> References: <20030414124016.O39446@sasami.jurai.net> <20030415.082727.65119004.imp@bsdimp.com> <20030415102955.S99028@sasami.jurai.net> X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: sobomax@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Apr 2003 14:36:41 -0000 In message: <20030415102955.S99028@sasami.jurai.net> "Matthew N. Dodd" writes: : On Tue, 15 Apr 2003, M. Warner Losh wrote: : > Yup. Here's the patch I came up with. Care to review? : : I'd like to read the BARs and see if its enabled so we can emit a warning : if its not (and a driver is requesting it.) How do you tell if a BAR is enabled? I assume you mean 'check to see if the BAR has an allocated resource' here? In that case, my XXX applies :-( We should allocate a resonable resource. : This may be an early notifiation we can provide to users that their box : may not be setup correctly. Sounds reasonable. : Other than that, it looks fine. OK. Warner