From owner-p4-projects@FreeBSD.ORG Mon Aug 31 18:27:57 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id ED267106568B; Mon, 31 Aug 2009 18:27:56 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B1A1D1065670 for ; Mon, 31 Aug 2009 18:27:56 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A05558FC0A for ; Mon, 31 Aug 2009 18:27:56 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n7VIRuSO028313 for ; Mon, 31 Aug 2009 18:27:56 GMT (envelope-from hselasky@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n7VIRu9B028311 for perforce@freebsd.org; Mon, 31 Aug 2009 18:27:56 GMT (envelope-from hselasky@FreeBSD.org) Date: Mon, 31 Aug 2009 18:27:56 GMT Message-Id: <200908311827.n7VIRu9B028311@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to hselasky@FreeBSD.org using -f From: Hans Petter Selasky To: Perforce Change Reviews Cc: Subject: PERFORCE change 168019 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Aug 2009 18:27:57 -0000 http://perforce.freebsd.org/chv.cgi?CH=168019 Change 168019 by hselasky@hselasky_laptop001 on 2009/08/31 18:27:32 USB CORE: - Fix NULL-pointer dereference in usb_endpoint_foreach(). The function in question is currently not used anywhere. - Report and patch from: Patroklos Argyroudis at census, inc PR: usb/138389 Affected files ... .. //depot/projects/usb/src/sys/dev/usb/usb_device.c#52 edit Differences ... ==== //depot/projects/usb/src/sys/dev/usb/usb_device.c#52 (text+ko) ==== @@ -367,12 +367,14 @@ struct usb_endpoint * usb_endpoint_foreach(struct usb_device *udev, struct usb_endpoint *ep) { - struct usb_endpoint *ep_end = udev->endpoints + udev->endpoints_max; + struct usb_endpoint *ep_end; /* be NULL safe */ if (udev == NULL) return (NULL); + ep_end = udev->endpoints + udev->endpoints_max; + /* get next endpoint */ if (ep == NULL) ep = udev->endpoints;