Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 02 Nov 2012 11:17:26 +0100
From:      nemysis <nemysis@gmx.ch>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        jgh@FreeBSD.org
Subject:   ports/173293: [PATCH] graphics/cbview: Makefile changed, OptionsNG, take maintainership
Message-ID:  <20121102101730.4E66E975@hub.freebsd.org>
Resent-Message-ID: <201211021020.qA2AK1mB003442@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         173293
>Category:       ports
>Synopsis:       [PATCH] graphics/cbview: Makefile changed, OptionsNG, take maintainership
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 02 10:20:01 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     nemysis
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:46:30 UTC
>Description:

- Take maintainership

Makefile changed:
+LICENSE=	GPLv2
+PORTDOCS=	Changes README TODO
+.include <bsd.port.options.mk>
+.if ${PORT_OPTIONS:MDOCS}

Changed and refined
 post-patch:
 do-install:

Added WWW in
pkg-descr

Generated and tested manually, tested with port test and with RedPorts (all RELEASES, CLANG), sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:

portlint -A
looks fine.

port test: clean

Build log

https://redports.org/buildarchive/20121101232730-41631/

>Fix:

--- cbview-0.06_8.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/graphics/cbview/Makefile ./Makefile
--- /usr/ports/graphics/cbview/Makefile	2012-06-28 20:37:12.000000000 +0200
+++ ./Makefile	2012-11-02 00:25:49.000000000 +0100
@@ -11,8 +11,10 @@
 CATEGORIES=	graphics perl5
 MASTER_SITES=	http://www.sourcefiles.org/Toys/Humor/
 
-MAINTAINER=	ports@FreeBSD.org
-COMMENT=	A viewer/converter for CBR/CBZ comic book archives
+MAINTAINER=	nemysis@gmx.ch
+COMMENT=	Viewer/converter for CBR/CBZ comic book archives
+
+LICENSE=	GPLv2
 
 RUN_DEPENDS=	unrar:${PORTSDIR}/archivers/unrar \
 		unzip:${PORTSDIR}/archivers/unzip \
@@ -23,19 +25,21 @@
 USE_PERL5=	yes
 
 PLIST_FILES=	bin/${PORTNAME}
-PORTDOCS=	COPYING Changes INSTALL README TODO
+
+PORTDOCS=	Changes README TODO
+
+.include <bsd.port.options.mk>
 
 post-patch:
-	@${REINPLACE_CMD} -e 's|perl -w|env perl|g' \
+	@${REINPLACE_CMD} -e 's|/usr/bin/perl -w|${PERL}|' \
 		${WRKSRC}/${PORTNAME}
 
 do-install:
-	@${INSTALL_SCRIPT} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin/
-.ifndef (NOPORTDOCS)
-	@${MKDIR} ${DOCSDIR}
-.for i in ${PORTDOCS}
-	@${INSTALL_DATA} ${WRKSRC}/${i} ${DOCSDIR}
-.endfor
+	${INSTALL_SCRIPT} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin/
+
+.if ${PORT_OPTIONS:MDOCS}
+	${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>
diff -ruN --exclude=CVS /usr/ports/graphics/cbview/pkg-descr ./pkg-descr
--- /usr/ports/graphics/cbview/pkg-descr	2009-02-01 08:24:14.000000000 +0100
+++ ./pkg-descr	2012-11-02 00:42:29.000000000 +0100
@@ -1,2 +1,4 @@
 CBView is a viewer/converter for CBR/CBZ comic book archives, written with
 gtk2-perl.
+
+WWW: http://www.sourcefiles.org/Toys/Humor/
--- cbview-0.06_8.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121102101730.4E66E975>