From owner-freebsd-current@freebsd.org  Tue Jul 11 16:44:20 2017
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9F600DA4990
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Tue, 11 Jul 2017 16:44:20 +0000 (UTC)
 (envelope-from truckman@FreeBSD.org)
Received: from gw.catspoiler.org (unknown [IPv6:2602:304:b010:ef20::f2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "gw.catspoiler.org", Issuer "gw.catspoiler.org" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 7A2987ACEF
 for <freebsd-current@FreeBSD.org>; Tue, 11 Jul 2017 16:44:20 +0000 (UTC)
 (envelope-from truckman@FreeBSD.org)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
 by gw.catspoiler.org (8.15.2/8.15.2) with ESMTP id v6BGiDvN026531
 for <freebsd-current@FreeBSD.org>; Tue, 11 Jul 2017 09:44:17 -0700 (PDT)
 (envelope-from truckman@FreeBSD.org)
Message-Id: <201707111644.v6BGiDvN026531@gw.catspoiler.org>
Date: Tue, 11 Jul 2017 09:44:13 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
Subject: r320183 (rpc.lockd cleanup) breaks virtualbox-ose build
To: freebsd-current@FreeBSD.org
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Jul 2017 16:44:20 -0000

This is a really strange problem ...

Last week I upgraded my 12.0-CURRENT package build box from r318774 to
r320570.  I also upgraded the poudriere jail to match.  When I went to
build packages, the virtualbox-ose build failed due to ar segfaulting.

To debug I created a new 12.0-CURRENT poudriere jail with rev r318774
and the build passed.   I then bisected, which took most of the last
week, and found that this commit is what is causing the breakage:

  r320183 | delphij | 2017-06-20 23:34:06 -0700 (Tue, 20 Jun 2017) | 12 lines

  Reduce code duplication in rpc.lockd.

  Reuse create_service code instead of duplicating it in
  lookup_addresses for kernel NLM.

  As a (good) side effect this also fixed a few issues that were
  already fixed in the former but never applied to the latter.

and it only touches usr.sbin/rpc.lockd/lockd.c.

If I rebuild the r320570 jail with the r320183 change backed out, and
then I can successfully build virtualbox-ose.  I confirmed this on
another machine.

I have no idea why the rpc.lockd source would affect ar inside a
poudriere jail where NFS isn't used.  Like I said, really strange ...
ex