From owner-svn-ports-all@freebsd.org Fri Apr 7 21:37:38 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AE128D33E1D; Fri, 7 Apr 2017 21:37:38 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8FF10FCD; Fri, 7 Apr 2017 21:37:38 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id B87A05E56; Fri, 7 Apr 2017 21:37:37 +0000 (UTC) Date: Fri, 7 Apr 2017 21:37:37 +0000 From: Alexey Dokuchaev To: Matthew Rezny Cc: Jan Beich , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r437953 - in head/lang/beignet: . files Message-ID: <20170407213737.GB32261@FreeBSD.org> References: <201704071930.v37JUBGj017948@repo.freebsd.org> <24496938.jsC6qZ9reS@workstation.reztek> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24496938.jsC6qZ9reS@workstation.reztek> User-Agent: Mutt/1.7.1 (2016-10-04) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 21:37:38 -0000 On Fri, Apr 07, 2017 at 10:53:27PM +0200, Matthew Rezny wrote: > On Friday 07 April 2017 22:23:18 Jan Beich wrote: > > > +USE_LDCONFIG= ${LOCALBASE}/lib/${PORTNAME} > > > > Why do you need ldconfig hints for dlopen(3)? libcl.so embeds absolute > > paths for libgbe.so and libgbeinterp.so + absolute path via ocl-icd > > config in /usr/local/etc/OpenCL/vendors/intel-beignet.icd > > > > Please, don't turn portlint into a cargo cult. > > Nothing to do with portlint, just following what is written in the > Porter's Handbook about ports that install shared libraries and > USE_LDCONFIG. Blindly following the PHB (or portlint) is still merely cargo-culting. USE_LDCONFIG is bogus for *.so's that are not being normally linked by consumers, but dlopen(3)ed during runtime instead. ./danfe