From owner-freebsd-hackers@FreeBSD.ORG  Sun Aug 31 09:52:20 2003
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C57BD16A4BF; Sun, 31 Aug 2003 09:52:20 -0700 (PDT)
Received: from smtp02.mrf.mail.rcn.net (smtp02.mrf.mail.rcn.net
	[207.172.4.61])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1518C43FB1; Sun, 31 Aug 2003 09:52:20 -0700 (PDT)
	(envelope-from roberthuff@rcn.com)
Received: from 209-6-102-154.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com
	([209.6.102.154] helo=jerusalem.litteratus.org.litteratus.org)
	by smtp02.mrf.mail.rcn.net with esmtp (Exim 3.35 #4)
	id 19tVR5-0001Cr-00; Sun, 31 Aug 2003 12:52:19 -0400
From: Robert Huff <roberthuff@rcn.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16210.10178.513524.898335@jerusalem.litteratus.org>
Date: Sun, 31 Aug 2003 12:52:18 -0400
To: hackers@freebsd.org
In-Reply-To: <16209.62524.183726.612751@hyde.home.loc>
References: <16208.36799.970894.848331@hyde.home.loc>
	<20030830120438.GA29217@spc.org>
	<16209.62524.183726.612751@hyde.home.loc>
X-Mailer: VM 7.11 under 21.5  (beta13) "cauliflower" XEmacs Lucid
cc: questions@freebsd.org
Subject: Re: USB -> PS/2
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 31 Aug 2003 16:52:20 -0000


Walter C. Pelissero writes:

>  Ok, today I spent some time deciphering the ums log and came up
>  with this patch.

	deletia

>  Unfortunately my knowledge (or rather lack of it) of the USB/UMS
>  driver doesn't give me very much confidence that I didn't break
>  something else.
>  
>  What was that conditional return suposed to protect from?
>  Is it safe to remove it?

	The accepted way of finding out would be to do a send-pr to bring
it to the formal attention of the usual suspects.  (I can't seem to
find an appropriate item - anyone got suggestions?)


				Robert Huff