Date: Sat, 21 Dec 2013 21:57:54 +0000 (UTC) From: Chris Rees <crees@FreeBSD.org> To: doc-committers@freebsd.org, svn-doc-all@freebsd.org, svn-doc-head@freebsd.org Subject: svn commit: r43363 - head/en_US.ISO8859-1/books/porters-handbook Message-ID: <201312212157.rBLLvsLr027169@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: crees Date: Sat Dec 21 21:57:54 2013 New Revision: 43363 URL: http://svnweb.freebsd.org/changeset/doc/43363 Log: Remove outdated note about USE_RCORDER Add suggestion to use devel/rclint to check rc scripts Scripts ending .sh.in were renamed a while ago, so make the comment regarding those less prominent Approved by: gjb (mentor) Modified: head/en_US.ISO8859-1/books/porters-handbook/book.xml Modified: head/en_US.ISO8859-1/books/porters-handbook/book.xml ============================================================================== --- head/en_US.ISO8859-1/books/porters-handbook/book.xml Sat Dec 21 01:05:16 2013 (r43362) +++ head/en_US.ISO8859-1/books/porters-handbook/book.xml Sat Dec 21 21:57:54 2013 (r43363) @@ -9905,15 +9905,6 @@ post-patch: <link linkend="using-sub-files">the relevant section</link>.</para> - <para>Prior to &os; 6.1-RELEASE, integration with - &man.rcorder.8; is available by using - <varname>USE_RCORDER</varname> instead of - <varname>USE_RC_SUBR</varname>. However, use of this method - is not necessary unless the port has an option to install - itself in the base, or the service needs to run prior to the - <filename>FILESYSTEMS</filename> <filename>rc.d</filename> - script in the base.</para> - <para>As of &os; 6.1-RELEASE, local <filename>rc.d</filename> scripts (including those installed by ports) are included in the overall &man.rcorder.8; of the @@ -9985,11 +9976,6 @@ run_rc_command "$1"</programlisting> <literal>_enable</literal> variable is not optional, and should use the ":" for the default.</para> - <note> - <para>No new scripts should be added with the - <filename>.sh</filename> suffix.</para> - </note> - <sect2> <title>Pre-Commit Checklist</title> @@ -9998,12 +9984,16 @@ run_rc_command "$1"</programlisting> before committing one, please consult the following checklist to be sure that it is ready.</para> + <para>The <package role="port">devel/rclint</package> + port can check for most of these, but it is not a + substitute for proper review.</para> + <procedure> <step> <para>If this is a new file, does it have <filename>.sh</filename> in the file name? If so that should be changed to just <filename>file.in</filename> - since new <filename>rc.d</filename> files may not end + since <filename>rc.d</filename> files may not end with that extension.</para> </step>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312212157.rBLLvsLr027169>