From owner-svn-ports-all@FreeBSD.ORG Thu Mar 14 18:07:31 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 235659CB for ; Thu, 14 Mar 2013 18:07:31 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-ve0-f169.google.com (mail-ve0-f169.google.com [209.85.128.169]) by mx1.freebsd.org (Postfix) with ESMTP id C1E37110 for ; Thu, 14 Mar 2013 18:07:30 +0000 (UTC) Received: by mail-ve0-f169.google.com with SMTP id 15so1937537vea.14 for ; Thu, 14 Mar 2013 11:07:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=gz0N3rknsIXN1EhsEcZM9KWqMqjTZU+0kNPKjAqEn3Q=; b=B95JZw4OS6ue2P/e4kiTYzEk/xPYK27rveQkgXei85rgh3ltGRMnCr/XVhVEd83SsC rp1zIkcDbMd+VprnkhSb0YazbSgWJ8KXetzvUuhieg2aRucssEucc7xdZ1+uA0+Tncfx D58CZwzGlFyOe51wpaiTV8hT7ATTevzQ6zWv9anY50kZDKbY9UAL5ysJFpn/rsIOappR E8O3lyBUvttkFAocLkMEkKGIJXLTO6IuGmkSdyKYsFIgkI4rSShobYTRS9dQWaxOEbd3 NecwdMqNkHYFFBqUh9YuNGwLJF/iZpgJKa4D1f148ALA2tLYYA3DETMwsZYg/FNbZwA4 8kQw== MIME-Version: 1.0 X-Received: by 10.58.143.116 with SMTP id sd20mr3079759veb.39.1363284449750; Thu, 14 Mar 2013 11:07:29 -0700 (PDT) Sender: bsd-src@helfman.org Received: by 10.58.30.79 with HTTP; Thu, 14 Mar 2013 11:07:29 -0700 (PDT) In-Reply-To: <20130314174630.GA35403@FreeBSD.org> References: <201303132159.r2DLx1QL092713@svn.freebsd.org> <20130314070455.GA42406@hatter> <20130314075330.GA94901@FreeBSD.org> <201303132359.22984.beech@freebsd.org> <20130314081701.GA6014@FreeBSD.org> <20130314165712.GA8275@FreeBSD.org> <20130314174630.GA35403@FreeBSD.org> Date: Thu, 14 Mar 2013 11:07:29 -0700 X-Google-Sender-Auth: GIScyXC4Q9mwZYRL1RWvM3676qg Message-ID: Subject: Re: svn commit: r314117 - head/games/kye From: Jason Helfman To: Alexey Dokuchaev X-Gm-Message-State: ALoCoQlrPbwUV9vb+L+m9gTh1zpnWDMlZAdVO6ox57Ca9WVZfRnBth/3jrbHSLw5R+6k91VeazaP Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , Beech Rintoul , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2013 18:07:31 -0000 On Thu, Mar 14, 2013 at 10:46 AM, Alexey Dokuchaev wrote: > On Thu, Mar 14, 2013 at 10:37:51AM -0700, Jason Helfman wrote: > > On Thu, Mar 14, 2013 at 9:57 AM, Alexey Dokuchaev > wrote: > > > Do you still disagree that PORTDOCS lines should be removed from > pkg-plist > > > in favor of PORTDOCS set in the Makefile? > > > > I completely agree with you, however since PLIST_SUB isn't doing anything > > in the Makefile, nor the pkg-plist, I really don't see the use for it. > For > > some reason, the maintainer is using it, and I trusted that it had built > > fine per committer. > > It's not about PLIST_SUB being in the Makefile, or pkg-plist, or anywhere > :) > In fact, it's not about PLIST_SUB logic at all, it's perfectly fine. > > The problem is that having *both* PORTDOCS being set in Makefile and the > very same docs listed in pkg-plist is wrong, and should be fixed, for the > obvious reasons. > > ./danfe > > Again, I agree with you. As I had noted, I trusted that it was built with no issue. If you wish to fix it, please take whatever action you see fit. -jgh