From owner-freebsd-net@freebsd.org Wed Mar 22 03:59:51 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8440FD17B0B for ; Wed, 22 Mar 2017 03:59:51 +0000 (UTC) (envelope-from ermal.luci@gmail.com) Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4956965C for ; Wed, 22 Mar 2017 03:59:51 +0000 (UTC) (envelope-from ermal.luci@gmail.com) Received: by mail-io0-x22d.google.com with SMTP id l7so59799915ioe.3 for ; Tue, 21 Mar 2017 20:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=+UibLifpseIprdwr2DNmB1xChRjLW+W2U49/w9oZVLI=; b=YMjXQqsEloN2sFy+KunB4EK6GFNANwbOGwXHxvybu26AK8PKfIvqjesViAimY8sTTY Dva0Z1GcNgISYOQCrJBdCNY73Mw9gccJxxqSDLZqWiI7Up7GmMhRM1/H/6VGGFLNrvAu TGrTEpEaiUdzks9a9fS10CyKsyRrBrzpgWch3aEeqN8t8MukfwxXpmOEmZoD8gR6vdJb LO9F/Rnn3aepGmcEf/DWMdW51PpG0EqbH7B/1b6SUW+rhSLKu1eT4FENJKfzABrCIpQj zAUXcPz/WNLrip90d7NFf9RvYDdW8/d9tePf5kCan806dBwfngWsiW7aTjTd6Yg+i9pC hVCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=+UibLifpseIprdwr2DNmB1xChRjLW+W2U49/w9oZVLI=; b=jo5egQCTxVk1JQJ8nX5DCk1Gkdi8j9vXF6H4SuDrkMvSfz8HZu7aa3RmgLvo5WlI/T XXy+cSDtpj9yuAN6rdAj5kmMmyCIF6iYCWyCmgPSGThVm0f1BHupRHCigzX7WhWNRGc8 FL/Xheew2PW3Tp5eJENcGnizCBocnXYbfR123arAbmIf32764F4wCXAIYYvP5i/rhaMu 8xlwNuFNKUFGdvwLx0k6Nbt6vQHqJVmBHri+qnZh6JdO3mBuqm0fuDkgI04kQ303Fi2U emx5dZSTv3RC1WffPdyz5/hPaU8hb1BInRp+QbthK6Ys1qXWCUr+pK1UvyabVH7yseQi 0hxQ== X-Gm-Message-State: AFeK/H3JYMqsXSTEAhHzNUzuJyGc1U4nUfYKnRaE6nDS+ojkgOGMTwwobaB/KqkzSv9Isf6ts+Rwf6tmfmyBhw== X-Received: by 10.107.155.16 with SMTP id d16mr33971108ioe.125.1490155190638; Tue, 21 Mar 2017 20:59:50 -0700 (PDT) MIME-Version: 1.0 Sender: ermal.luci@gmail.com Received: by 10.107.149.135 with HTTP; Tue, 21 Mar 2017 20:59:50 -0700 (PDT) In-Reply-To: References: From: =?UTF-8?Q?Ermal_Lu=C3=A7i?= Date: Tue, 21 Mar 2017 20:59:50 -0700 X-Google-Sender-Auth: _Xq6TigvxH_xBVWuDnJHvukJzhw Message-ID: Subject: Re: if_epair altq support problem To: =?UTF-8?B?w5Z6a2FuIEtJUklL?= Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 03:59:51 -0000 On Tue, Mar 21, 2017 at 5:26 AM, =C3=96zkan KIRIK w= rote: > Hello, > > I sent this email also to freebsd-pf list. But I think that the main > problem is belongs to sys/net/if_epair.c. > > I'm using FreeBSD 10.3-p17 amd64. epair pseudo device is listed as > supperted deviced at the Man page of altq(4). > From man page of altq : > > *SUPPORTED DEVICES = * > > The driver modifications described in altq(9) > apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports> > are required to use a cer- > tain network card with *ALTQ*. They have been applied to the > following > hardware drivers: ae(4) > apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > age(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > alc(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > ale(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > an(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > ath(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > aue(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > axe(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > bce(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > bfe(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > bge(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > bxe(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > cas(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > cxgbe(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > dc(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > de(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > ed(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > em(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > ep(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > epair(4) apropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, > .... > > But while trying to use it the system says that it's not suppoerted. I > tried on FreeBSD 11 also. The output is below: > > pf.conf : > altq on epair0b hfsc bandwidth 1Mb queue { ftp, ssh, icmp, other } > queue ftp bandwidth 30% priority 0 hfsc (upperlimit 99%) > queue ssh bandwidth 30% priority 2 hfsc (upperlimit 99%) > queue icmp bandwidth 10% priority 2 hfsc (upperlimit 99%) > queue other bandwidth 30% priority 1 hfsc (default upperlimit 99%) > > > # ifconfig epair0 create > # ifconfig epair0a up > # ifconfig epair0b up > # pfctl -f pf.conf > pfctl: epair0b: driver does not support altq > > # sysctl -a | grep ALTQ > options ALTQ_NOPCC > options ALTQ_PRIQ > options ALTQ_CDNR > options ALTQ_HFSC > options ALTQ_RIO > options ALTQ_RED > options ALTQ_CBQ > options ALTQ > > > I have a look on /usr/src/sys/net/if_epair.c, and found the ALTQ section: > > 514 #ifdef ALTQ > 515 /* Support ALTQ via the clasic if_start() path. */ > 516 IF_LOCK(&ifp->if_snd); > 517 if (ALTQ_IS_ENABLED(&ifp->if_snd)) { > 518 ALTQ_ENQUEUE(&ifp->if_snd, m, NULL, error); > 519 if (error) > 520 ifp->if_snd.ifq_drops++; > 521 IF_UNLOCK(&ifp->if_snd); > 522 if (!error) { > 523 ifp->if_obytes +=3D len; > 524 if (mflags & (M_BCAST|M_MCAST)) > 525 ifp->if_omcasts++; > 526 > 527 if ((ifp->if_drv_flags & IFF_DRV_OACTIVE) = =3D=3D > 0) > 528 epair_start_locked(ifp); > 529 else > 530 (void)epair_add_ifp_for_ > draining(ifp); > 531 } > 532 return (error); > 533 } > 534 IF_UNLOCK(&ifp->if_snd); > 535 #endif > > Just apply manually this patch to make it work. diff --git a/sys/net/if_epair.c b/sys/net/if_epair.c index 540f06c..04733a5 100644 --- a/sys/net/if_epair.c +++ b/sys/net/if_epair.c @@ -827,9 +827,11 @@ epair_clone_create(struct if_clone *ifc, char *name, size_t len, caddr_t params) ifp->if_capabilities =3D IFCAP_VLAN_MTU; ifp->if_capenable =3D IFCAP_VLAN_MTU; ifp->if_start =3D epair_start; + if_setstartfn(ifp, epair_start); + if_setsendqlen(ifp, ifqmaxlen); + if_setsendqready(ifp); ifp->if_ioctl =3D epair_ioctl; ifp->if_init =3D epair_init; - ifp->if_snd.ifq_maxlen =3D ifqmaxlen; /* Assign a hopefully unique, locally administered etheraddr. */ eaddr[0] =3D 0x02; eaddr[3] =3D (ifp->if_index >> 8) & 0xff; @@ -852,10 +854,11 @@ epair_clone_create(struct if_clone *ifc, char *name, size_t len, caddr_t params) ifp->if_flags =3D IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST; ifp->if_capabilities =3D IFCAP_VLAN_MTU; ifp->if_capenable =3D IFCAP_VLAN_MTU; - ifp->if_start =3D epair_start; + if_setstartfn(ifp, epair_start); + if_setsendqlen(ifp, ifqmaxlen); + if_setsendqready(ifp); ifp->if_ioctl =3D epair_ioctl; ifp->if_init =3D epair_init; - ifp->if_snd.ifq_maxlen =3D ifqmaxlen; /* We need to play some tricks here for the second interface. */ strlcpy(name, epairname, len); error =3D if_clone_create(name, len, (caddr_t)scb); > I have no idea that why it says that it doesn't support altq altough the > source code contains ALTQ section. > > > Regards > =C3=96zkan KIRIK > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" --=20 Ermal