From owner-freebsd-ports@FreeBSD.ORG Mon Mar 26 02:52:38 2007 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C3DF016A402 for ; Mon, 26 Mar 2007 02:52:38 +0000 (UTC) (envelope-from tmclaugh@sdf.lonestar.org) Received: from straycat.dhs.org (c-24-63-86-11.hsd1.ma.comcast.net [24.63.86.11]) by mx1.freebsd.org (Postfix) with ESMTP id 4450313C455 for ; Mon, 26 Mar 2007 02:52:37 +0000 (UTC) (envelope-from tmclaugh@sdf.lonestar.org) Received: from [192.168.1.127] (bofh.straycat.dhs.org [192.168.1.127]) by straycat.dhs.org (8.13.8/8.13.8) with ESMTP id l2Q2Nq7f026713; Sun, 25 Mar 2007 22:23:52 -0400 (EDT) From: Tom McLaughlin To: Marcin Simonides In-Reply-To: <460580F9.80602@studio4plus.com> References: <460580F9.80602@studio4plus.com> Content-Type: text/plain Date: Sun, 25 Mar 2007 22:23:37 -0400 Message-Id: <1174875817.1773.18.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.10.0 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: freebsd-ports@freebsd.org Subject: Re: New port - please review X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2007 02:52:38 -0000 On Sat, 2007-03-24 at 20:50 +0100, Marcin Simonides wrote: > I've made a port for gnome-subtitles, a subtitle editor with video > preview (http://gnome-subtitles.sourceforge.net/). > > Since this is my first port I'd like to ask you to review and test it > before I submit it. > Looks good, just a few changes. - change HAS_CONFIGURE to GNU_CONFIGURE - remove the DISTNAME line since it's not needed - add gnomeprefix to the USE_GNOME line so it installs correctly within the Gnome hierarchy. That'll affect the pkg-plist. The two files installed under share/ should then be installed under share/gnome/ - The two patch files should be named: patch-src_GnomeSubtitles_Execution_Executable.cs patch-src_GnomeSubtitles_Execution_gnome-subtitles.in to reflect the path to the files within the distfile. Just shar the port up (http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-submitting.html) and send-pr it. CC. tmclaugh@FreeBSD.org on the PR and I'll take care of it. tom > The file may be downloaded here: > http://marcin.studio4plus.com/files/gnome-subtitles-port.tgz > Just untar it in /usr/ports, multimedia/gnome-subtitles will be created. > > It requires (quoting the website): > > Mono >= 1.1 (mono to run, gmcs to build) > Gtk-Sharp >= 2.8 > Glade-Sharp >= 2.8 > Gnome-Sharp >= 2.8 > Gtk+ >= 2.8 > > and optionally mplayer. I hope that adding only the highest-level > dependencies (eg. no gtk, since it is required by gtk-sharp) is enough. > > It works fine on my system (6.2-stable) but package registration takes a > very long time. Is it normal (there is a lot of gnome dependencies to > register, I think) or is something wrong? > > Thanks in advance! -- | tmclaugh at sdf.lonestar.org tmclaugh at FreeBSD.org | | FreeBSD http://www.FreeBSD.org | | BSD# http://www.mono-project.com/Mono:FreeBSD |