From owner-svn-src-all@FreeBSD.ORG Mon Apr 20 16:20:10 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A2D164FE; Mon, 20 Apr 2015 16:20:10 +0000 (UTC) Received: from mail106.syd.optusnet.com.au (mail106.syd.optusnet.com.au [211.29.132.42]) by mx1.freebsd.org (Postfix) with ESMTP id 68B12A82; Mon, 20 Apr 2015 16:20:10 +0000 (UTC) Received: from c211-30-166-197.carlnfd1.nsw.optusnet.com.au (c211-30-166-197.carlnfd1.nsw.optusnet.com.au [211.30.166.197]) by mail106.syd.optusnet.com.au (Postfix) with ESMTPS id CF6B43C4483; Tue, 21 Apr 2015 02:20:00 +1000 (AEST) Date: Tue, 21 Apr 2015 02:19:52 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: John Baldwin cc: Justin Hibbits , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r281721 - head/sys/sys In-Reply-To: <476583045.Qcb6O2DFtY@ralph.baldwin.cx> Message-ID: <20150421020808.D10623@besplex.bde.org> References: <201504190033.t3J0XMDX041769@svn.freebsd.org> <476583045.Qcb6O2DFtY@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=L/MkHYj8 c=1 sm=1 tr=0 a=KA6XNC2GZCFrdESI5ZmdjQ==:117 a=PO7r1zJSAAAA:8 a=kj9zAlcOel0A:10 a=JzwRw_2MAAAA:8 a=UsB5EdndRrl7-tn2VpUA:9 a=CjuIK1q_8ugA:10 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2015 16:20:10 -0000 On Mon, 20 Apr 2015, John Baldwin wrote: > On Sunday, April 19, 2015 12:33:22 AM Justin Hibbits wrote: >> Log: >> Fix the build. Commit the last part of e500 PMC. >> ... >> @@ -136,6 +138,7 @@ enum pmc_cputype { >> __PMC_CLASS(MIPS74K) /* MIPS 74K */ \ >> __PMC_CLASS(PPC7450) /* Motorola MPC7450 class */ \ >> __PMC_CLASS(PPC970) /* IBM PowerPC 970 class */ \ >> + __PMC_CLASS(E500) /* Freescale e500 class */ \ >> __PMC_CLASS(SOFT) /* Software events */ > > Note that each time a PMC_CLASS is added, the ABI for pmccontrol -L > breaks since the enum value of the "SOFT" class changes. We should > perhaps fix the value of SOFT to make this less painful (just as we > fix the values for PMC_CPU so that those don't change). Enums should never be used in ABIs, since their size can be anything large enough. They also cause namespace problems. The whole enum declaration must be exposed in any header that uses an enum type. Bruce