Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 29 Jan 2020 11:17:36 +0100
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Christoph Moench-Tegeder <cmt@burggraben.net>
Cc:        Greg V <greg@unrelenting.technology>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r516629 - head/net/liferea
Message-ID:  <pnf2-bm7z-wny@FreeBSD.org>
References:  <201911041019.xA4AJYqc047310@repo.freebsd.org> <20191104103901.GA2476@elch.exwg.net> <20200128001023.GA62291@elch.exwg.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Christoph Moench-Tegeder <cmt@burggraben.net> writes:

[ ... http://docs.freebsd.org/cgi/mid.cgi?20200128001023.GA62291 ... ]
> So, opinions against doing just that? I've no idea if it would even make
> sense to try to support WPE on FreeBSD or if it's just something we
> inherited "because it's there" as someone upstream had declared
> underpowered mobile devices to be the future.

WPE dependency was added in https://bugs.webkit.org/show_bug.cgi?id=197944
WPE renderer is unstable for me under Sway (Wayland compositor) e.g.,
Midori hangs shortly after startup. Greg, can you confirm?

I've used the following diff to test WPE disabled.

diff --git a/net/liferea/Makefile b/net/liferea/Makefile
index b6437109e11a..7a775e48d2eb 100644
--- a/net/liferea/Makefile
+++ b/net/liferea/Makefile
@@ -11,8 +11,6 @@ COMMENT=	Simple RSS/RDF feed reader
 
 LICENSE=	GPLv2
 
-BROKEN=		fails to build
-
 BUILD_DEPENDS=	gsettings-desktop-schemas>=0:devel/gsettings-desktop-schemas
 LIB_DEPENDS=	libsoup-2.4.so:devel/libsoup \
 		libwebkit2gtk-4.0.so:www/webkit2-gtk3 \
diff --git a/www/webkit2-gtk3/Makefile b/www/webkit2-gtk3/Makefile
index 4f92b2b1aefe..70a9a55dcd55 100644
--- a/www/webkit2-gtk3/Makefile
+++ b/www/webkit2-gtk3/Makefile
@@ -3,6 +3,7 @@
 
 PORTNAME=	webkit
 PORTVERSION=	2.26.3
+PORTREVISION=	1
 CATEGORIES=	www
 MASTER_SITES=	https://webkitgtk.org/releases/
 PKGNAMESUFFIX=	2-gtk3
@@ -65,7 +66,7 @@ INSTALL_TARGET=		install
 
 BROWSER_PLUGINS_DIR?=	${LOCALBASE}/lib/browser_plugins/symlinks/webkit-gtk3
 
-OPTIONS_DEFINE=		DEBUG GEOIP WAYLAND
+OPTIONS_DEFINE=		DEBUG GEOIP WAYLAND WPE
 OPTIONS_DEFAULT=	GEOIP WAYLAND
 OPTIONS_SUB=		yes
 
@@ -91,9 +92,13 @@ GEOIP_BUILD_DEPENDS=	geoclue>=2.4.3:net/geoclue
 GEOIP_RUN_DEPENDS=	geoclue>=2.4.3:net/geoclue
 
 WAYLAND_CMAKE_BOOL=	ENABLE_WAYLAND_TARGET
-WAYLAND_LIB_DEPENDS=	libwayland-egl.so:graphics/wayland \
-			libwpe-1.0.so:www/libwpe \
+WAYLAND_LIB_DEPENDS=	libwayland-egl.so:graphics/wayland
+
+WPE_DESC=		Use WPEBackend-fdo instead of nested compositor
+WPE_CMAKE_BOOL=		USE_WPE_RENDERER
+WPE_LIB_DEPENDS=	libwpe-1.0.so:www/libwpe \
 			libWPEBackend-fdo-1.0.so:www/wpebackend-fdo
+WPE_IMPLIES=		WAYLAND
 
 post-patch:
 	@${REINPLACE_CMD} -e 's|/usr/lib/browser/plugins|${BROWSER_PLUGINS_DIR}|' \



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?pnf2-bm7z-wny>