Date: Thu, 09 May 2024 05:57:05 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Jimmy Olgeni <olgeni@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 170431212955 - main - net/benthos: Add new port Message-ID: <01d594e0622a5f7cf9081ac2ec7f5ec1@mail.infomaniak.com> In-Reply-To: <61d10e7b-e5b3-a6bd-86bf-52b7f7ce81c5@FreeBSD.org> References: <202405051444.445EiQgm028494@gitrepo.freebsd.org> <4b7b52121e9ca725f281b28c0485c25b@mail.infomaniak.com> <61d10e7b-e5b3-a6bd-86bf-52b7f7ce81c5@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2024-05-05T19:57:07.000+02:00, Jimmy Olgeni <olgeni@FreeBSD.org> wrote: > Hi, >=20 > On Sun, 5 May 2024, Daniel Engberg wrote: >=20 >=20 > > On 2024-05-05T16:44:26.000+02:00, Jimmy Olgeni <olgeni@FreeBSD.org> = wrote: > >=20 > > > The branch main has been updated by olgeni: > > > =20 > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D17043121295573db97= 77f6dd31364ee356$ > > > =20 > > > commit 17043121295573db9777f6dd31364ee356e3154c > > > Author: Jimmy Olgeni <olgeni@FreeBSD.org> > > > AuthorDate: 2024-05-05 14:08:37 +0000 > > > Commit: Jimmy Olgeni <olgeni@FreeBSD.org> > > > CommitDate: 2024-05-05 14:43:31 +0000 > > > =20 > > > net/benthos: Add new port > > > =20 > > ... > >=20 > > Please use ordering and variables as stated in Porters Handbook, > > https://docs.freebsd.org/en/books/porters-handbook/book/#using-go > =20 > I can drop the extra USE_GITHUB, GH_ACCOUNT, and GO_PKGNAME (works=20 > fine without) but is there anything else to fix? > (also PORTVERSION could be DISTVERSION) Hi, Sounds good, thanks! Best regards, Daniel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01d594e0622a5f7cf9081ac2ec7f5ec1>